CONTRIBUTING.md → .github/CONTRIBUTING.md

@@ -12,7 +12,7 @@
 All pull requests are welcome! By participating in this project, you
 agree to abide by our **[code of conduct]**.
 
-[code of conduct]: https://github.com/remarkablemark/html-react-parser/blob/master/CODE_OF_CONDUCT.md
+[code of conduct]: https://github.com/remarkablemark/html-react-parser/blob/master/.github/CODE_OF_CONDUCT.md
 
 [Fork], then clone the repository:
 

.github/ISSUE_TEMPLATE.md → .github/ISSUE_TEMPLATE/bug_report.md

@@ -1,9 +1,8 @@
-<!--
-Is this a bug report?
-
-* Yes: Continue filling out the template.
-* No: Delete the template and write in free form. (Apply a label to the issue if applicable.)
--->
+---
+name: Bug Report
+about: Report a bug
+labels: bug
+---
 
 ## Expected Behavior
 
@@ -32,3 +31,8 @@ Creating a bug demo will help speed up the process of resolving the issue:
 - Version:
 - Platform:
 - Browser:
+- OS:
+
+## Keywords
+
+<!-- Include keywords that might help others with the same problem find this issue. -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,17 @@
+---
+name: Feature Request
+about: Suggest improvements or new features
+labels: feature
+---
+
+## Problem
+
+<!-- What is missing or inconvenient without this improvement or feature? -->
+
+## Suggested Solution
+
+<!-- How do you suggest fixing the problem? Do any other tools already do it? -->
+
+## Keywords
+
+<!-- Include keywords that might help others with the same problem find this issue. -->

.github/ISSUE_TEMPLATE/question.md

@@ -0,0 +1,13 @@
+---
+name: Question
+about: Ask a question
+labels: question
+---
+
+## Question
+
+<!-- Check the README, issues, and discussions before asking your question. -->
+
+## Keywords
+
+<!-- Include keywords that might help others with the same question find this issue. -->

.size-limit.json

@@ -1,6 +1,6 @@
 [
   {
     "path": "dist/html-react-parser.min.js",
-    "limit": "10.541 KB"
+    "limit": "10.553 KB"
   }
 ]

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [3.0.7](https://github.com/remarkablemark/html-react-parser/compare/v3.0.6...v3.0.7) (2023-01-05)
+
+
+### Bug Fixes
+
+* **attributes-to-props:** don't convert value of option tag ([#790](https://github.com/remarkablemark/html-react-parser/issues/790)) ([bb4bf49](https://github.com/remarkablemark/html-react-parser/commit/bb4bf49b150be992917958813a7b17d1d7cef31c))
+
 ## [3.0.6](https://github.com/remarkablemark/html-react-parser/compare/v3.0.5...v3.0.6) (2022-12-25)
 
 

README.md

@@ -531,7 +531,7 @@ npx size-limit
 
 ### Code Contributors
 
-This project exists thanks to all the people who contribute. [[Contribute](https://github.com/remarkablemark/html-react-parser/blob/master/CONTRIBUTING.md)].
+This project exists thanks to all the people who contribute. [[Contribute](https://github.com/remarkablemark/html-react-parser/blob/master/.github/CONTRIBUTING.md)].
 
 [![Code Contributors](https://opencollective.com/html-react-parser/contributors.svg?width=890&button=false)](https://github.com/remarkablemark/html-react-parser/graphs/contributors)
 

lib/attributes-to-props.d.ts

@@ -10,6 +10,10 @@ export type Props = Record<string, string> & {
  * Converts HTML/SVG DOM attributes to React props.
  *
  * @param attributes - HTML/SVG DOM attributes.
+ * @param nodeName - DOM node name.
  * @returns - React props.
  */
-export default function attributesToProps(attributes: Attributes): Props;
+export default function attributesToProps(
+  attributes: Attributes,
+  nodeName?: string
+): Props;

lib/attributes-to-props.js

@@ -5,9 +5,10 @@ var utilities = require('./utilities');
  * Converts HTML/SVG DOM attributes to React props.
  *
  * @param {object} [attributes={}] - HTML/SVG DOM attributes.
+ * @param {string} [nodeName] - DOM node name.
  * @returns - React props.
  */
-module.exports = function attributesToProps(attributes) {
+module.exports = function attributesToProps(attributes, nodeName) {
   attributes = attributes || {};
 
   var valueOnlyInputs = {
@@ -43,6 +44,7 @@ module.exports = function attributesToProps(attributes) {
       // https://reactjs.org/docs/uncontrolled-components.html
       if (
         (propName === 'checked' || propName === 'value') &&
+        nodeName !== 'option' &&
         !inputIsValueOnly
       ) {
         propName = getPropName('default' + attributeNameLowerCased);

lib/dom-to-react.js

@@ -76,7 +76,7 @@ function domToReact(nodes, options) {
     if (skipAttributesToProps(node)) {
       setStyleProp(props.style, props);
     } else if (props) {
-      props = attributesToProps(props);
+      props = attributesToProps(props, node.name);
     }
 
     children = null;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "html-react-parser",
-  "version": "3.0.6",
+  "version": "3.0.7",
   "description": "HTML to React parser.",
   "author": "Mark <mark@remarkablemark.org>",
   "main": "index.js",
@@ -50,18 +50,18 @@
     "style-to-js": "1.1.2"
   },
   "devDependencies": {
-    "@commitlint/cli": "17.3.0",
-    "@commitlint/config-conventional": "17.3.0",
+    "@commitlint/cli": "17.4.0",
+    "@commitlint/config-conventional": "17.4.0",
     "@rollup/plugin-commonjs": "24.0.0",
     "@rollup/plugin-node-resolve": "15.0.1",
     "@size-limit/preset-big-lib": "8.1.0",
     "@types/react": "18.0.26",
-    "@typescript-eslint/parser": "5.47.0",
+    "@typescript-eslint/parser": "5.48.0",
     "benchmark": "2.1.4",
     "dtslint": "4.2.1",
-    "eslint": "8.30.0",
+    "eslint": "8.31.0",
     "eslint-plugin-prettier": "4.2.1",
-    "husky": "8.0.2",
+    "husky": "8.0.3",
     "jest": "29.3.1",
     "jest-environment-jsdom": "29.3.1",
     "lint-staged": "13.1.0",

test/attributes-to-props.test.js

@@ -186,6 +186,12 @@ describe('attributesToProps with HTML attribute', () => {
       expect(attributesToProps(attributes)).toEqual(props);
     }
   );
+
+  it('preserves value of option element', () => {
+    expect(attributesToProps({ value: 'foo' }, 'option')).toEqual({
+      value: 'foo'
+    });
+  });
 });
 
 describe('attributesToProps with SVG attribute', () => {