-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/rollback tag #1059
Fix/rollback tag #1059
Conversation
@webpro please take a look, this thing is blocking us from using the tool :( |
Thanks @cakeinpanic! It's an interesting feature, complete with a good test, let's try it out! |
🚀 This pull request is included in v17.0.0. See Release 17.0.0 for release notes. |
@webpro hi! altogether with this fix you have released node 16 deprecation altogether with dependency packages updates. we are using node 14.20 and can not upgrade to node 17 at the moment and started getting
is there a way to release also next minor on v16 with this fix only? |
🚀 This pull request is included in v16.3.0. See Release 16.3.0 for release notes. |
Alright then, although release-it v16 also required Node.js v16 |
I don't fancy going to back to supporting Node.js v14 or earlier, but I'll happily accept fixes against the v16 branch. |
@webpro thank you for fast response! release v 16 actually works fine with node 14 🫠
but i have made a mistake, we are using version 15 in our repos... I have actually found an uuuugly workaround using hooks, since revert of published tag is not our only issue – we dont want to publish an npm package at all if we ar enot able to push, so with my hook workaround this fix is not even needed :) |
lol |
Hi!
Fixing issue described in #1058
I tried to use standard rollback method, but because pushing to remote is async, it does not work on the
exit
hookIf it's crucial to have all rollback in one method, there are few options I have found
exit
explicitly and then get ability to usebeforeExit
hookWDYT?