Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to open the browser automatically on Windows system #1019

Merged
merged 2 commits into from Aug 13, 2023
Merged

fix: unable to open the browser automatically on Windows system #1019

merged 2 commits into from Aug 13, 2023

Conversation

13OnTheCode
Copy link
Contributor

Using await open(url, { wait: true }) can solve the issue of the browser not automatically opening on Windows devices. Additionally, a prompt has been added to the terminal to display the GitHub Release web interface URL, allowing users to manually copy and paste it into the browser for further operation if the browser does not open automatically.

@webpro
Copy link
Collaborator

webpro commented Jul 3, 2023

Thanks @13OnTheCode! Will try this when I can from a Windows machine.

The docs of open say that the wait option can be used to await the app exit, but that shouldn't affect the actual opening. Also:

On Windows, you have to explicitly specify an app for it to be able to wait.

This PR doesn't seem to do that? Anyway, I'll report back after some testing.

@13OnTheCode
Copy link
Contributor Author

This is an issue specific to Windows systems, and it has been confirmed by members of the community:
sindresorhus/open#298
pnp/cli-microsoft365#4409

The changes I made were based on a solution provided by the community:
pnp/cli-microsoft365#4409 (comment)

Until this issue is completely resolved, I believe this is currently the only available solution

@webpro webpro force-pushed the main branch 3 times, most recently from 6f71c01 to 97c233e Compare July 4, 2023 21:23
@webpro webpro merged commit 5069c30 into release-it:main Aug 13, 2023
2 of 11 checks passed
@13OnTheCode 13OnTheCode deleted the fix/issue-1017 branch August 13, 2023 10:46
@webpro
Copy link
Collaborator

webpro commented Aug 13, 2023

🚀 This pull request is included in v16.1.5. See Release 16.1.5 for release notes.

@webpro
Copy link
Collaborator

webpro commented Aug 13, 2023

Sorry for the wait, @13OnTheCode. Thanks again for the efforts and explanations.

@13OnTheCode
Copy link
Contributor Author

@webpro Don't worry, and thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants