Remove node-fetch and got from dependencies (#1133)

* Remove `node-fetch` and `got` from dependencies

* Remove console

* npm dedupe

* Try 22.4.1

* Try 22.5.1

* Try revert CI change

Author: hyoban

Diff for: lib/plugin/github/GitHub.js

@@ -2,7 +2,6 @@ import fs from 'node:fs';
 import path from 'node:path';
 import open from 'open';
 import { Octokit } from '@octokit/rest';
-import fetch from 'node-fetch';
 import { globby } from 'globby';
 import mime from 'mime-types';
 import _ from 'lodash';
@@ -177,8 +176,7 @@ class GitHub extends Release {
       userAgent: `release-it/${pkg.version}`,
       log: this.config.isDebug ? console : null,
       request: {
-        timeout,
-        fetch
+        timeout
       }
     };
 

Diff for: lib/plugin/gitlab/GitLab.js

@@ -1,8 +1,6 @@
 import fs from 'node:fs';
 import path from 'node:path';
-import got from 'got';
 import { globby } from 'globby';
-import { FormData, fileFromSync } from 'node-fetch';
 import _ from 'lodash';
 import Release from '../GitRelease.js';
 import { format, e } from '../../util.js';
@@ -30,22 +28,6 @@ class GitLab extends Release {
     this.certificateAuthorityOption = _.isEmpty(https) ? {} : { https };
   }
 
-  get client() {
-    if (this._client) return this._client;
-    const { tokenHeader } = this.options;
-    const { baseUrl } = this.getContext();
-    this._client = got.extend({
-      prefixUrl: baseUrl,
-      method: 'POST',
-      headers: {
-        'user-agent': 'webpro/release-it',
-        [tokenHeader]: this.token
-      },
-      ...this.certificateAuthorityOption
-    });
-    return this._client;
-  }
-
   async init() {
     await super.init();
 
@@ -179,8 +161,28 @@ class GitLab extends Release {
     const { baseUrl } = this.getContext();
     this.debug(Object.assign({ url: `${baseUrl}/${endpoint}` }, options));
     const method = (options.method || 'POST').toLowerCase();
-    const response = await this.client[method](endpoint, options);
-    const body = typeof response.body === 'string' ? JSON.parse(response.body) : response.body || {};
+    const { tokenHeader } = this.options;
+    const url = `${baseUrl}/${endpoint}${options.searchParams ? `?${new URLSearchParams(options.searchParams)}` : ''}`;
+    const headers = {
+      'user-agent': 'webpro/release-it',
+      [tokenHeader]: this.token
+    };
+    const requestOptions = {
+      method,
+      headers,
+      ...this.certificateAuthorityOption
+    };
+
+    const response = await fetch(
+      url,
+      options.json || options.body
+        ? {
+            ...requestOptions,
+            body: options.json ? JSON.stringify(options.json) : options.body
+          }
+        : requestOptions
+    );
+    const body = await response.json();
     this.debug(body);
     return body;
   }
@@ -239,7 +241,8 @@ class GitLab extends Release {
     const endpoint = `projects/${id}/uploads`;
 
     const body = new FormData();
-    body.set('file', fileFromSync(filePath));
+    const rawData = await fs.promises.readFile(filePath);
+    body.set('file', new Blob([rawData]), name);
     const options = { body };
 
     try {

Diff for: package-lock.json

@@ -86,14 +86,12 @@
     "execa": "8.0.1",
     "git-url-parse": "14.0.0",
     "globby": "14.0.2",
-    "got": "13.0.0",
     "inquirer": "9.3.2",
     "is-ci": "3.0.1",
     "issue-parser": "7.0.1",
     "lodash": "4.17.21",
     "mime-types": "2.1.35",
     "new-github-release-url": "2.0.0",
-    "node-fetch": "3.3.2",
     "open": "10.1.0",
     "ora": "8.0.1",
     "os-name": "5.1.0",
@@ -123,7 +121,7 @@
     "knip": "5.26.0",
     "memfs": "4.9.3",
     "mock-stdio": "1.0.3",
-    "nock": "13.5.4",
+    "nock": "14.0.0-beta.8",
     "prettier": "3.3.3",
     "remark-cli": "12.0.1",
     "remark-preset-webpro": "1.1.0",

Diff for: package.json

@@ -226,29 +226,24 @@ test('should not make requests in dry run', async t => {
   const options = { 'dry-run': true, git: { pushRepo }, gitlab: { releaseName: 'R', tokenRef } };
   const gitlab = factory(GitLab, { options });
   sinon.stub(gitlab, 'getLatestVersion').resolves('1.0.0');
-  const spy = sinon.spy(gitlab, 'client', ['get']);
 
   await runTasks(gitlab);
 
   const { isReleased, releaseUrl } = gitlab.getContext();
-  t.is(spy.get.callCount, 0);
+
   t.is(gitlab.log.exec.args[2][0], 'gitlab releases#uploadAssets');
   t.is(gitlab.log.exec.args[3][0], 'gitlab releases#createRelease "R" (1.0.1)');
   t.true(isReleased);
   t.is(releaseUrl, `${pushRepo}/-/releases`);
-  spy.get.restore();
 });
 
 test('should skip checks', async t => {
   const options = { gitlab: { tokenRef, skipChecks: true, release: true, milestones: ['v1.0.0'] } };
   const gitlab = factory(GitLab, { options });
-  const spy = sinon.spy(gitlab, 'client', ['get']);
 
   await t.notThrowsAsync(gitlab.init());
   await t.notThrowsAsync(gitlab.beforeRelease());
 
-  t.is(spy.get.callCount, 0);
-
   t.is(gitlab.log.exec.args.filter(entry => /checkReleaseMilestones/.test(entry[0])).length, 0);
 });