Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prerelease increment behavior #1303

Merged
merged 3 commits into from Sep 25, 2023
Merged

feat: add prerelease increment behavior #1303

merged 3 commits into from Sep 25, 2023

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Jan 22, 2023 •
edited

Allows to increment the prerelease number (https://semver.org/#spec-item-9).
It does NOT change ANY of the actual behavior
It introduces a new config variable or input "prerelease-identifier"

The prerelease number is increment ONLY when:

  • prerelease is true
  • prerelease-identifier is not empty

@neilime neilime changed the title test: factorize version tests test: feat: add pre-release increment behavior Jan 22, 2023
@neilime neilime changed the title test: feat: add pre-release increment behavior feat: add pre-release increment behavior Jan 22, 2023
@neilime neilime force-pushed the add-prerelease-suffix branch 4 times, most recently from c9c7d4f to 6d31423 Compare January 27, 2023 09:42
@neilime neilime force-pushed the add-prerelease-suffix branch 5 times, most recently from 2e10c97 to ff9ef6d Compare February 2, 2023 09:11
@neilime neilime force-pushed the add-prerelease-suffix branch 10 times, most recently from 7ea9399 to 3b49259 Compare April 11, 2023 16:25
@jetersen
Copy link
Member

Hi @neilime do you mind resolving the conflicts?

@neilime
Copy link
Contributor Author

neilime commented Apr 13, 2023

@jetersen done !

@neilime
Copy link
Contributor Author

neilime commented May 5, 2023

Hi @jetersen, any chance to review this PR, when you'll have time?

Thanks

@neilime neilime mentioned this pull request Jun 18, 2023
Open
@neilime neilime force-pushed the add-prerelease-suffix branch 2 times, most recently from 426d7f3 to 0805bb0 Compare June 18, 2023 15:37
@neilime neilime force-pushed the add-prerelease-suffix branch 2 times, most recently from cbce15f to 7ffefa9 Compare June 18, 2023 16:00
@jetersen
Copy link
Member

jetersen commented Jun 27, 2023 •
edited

@neilime I think we are missing an update to action.yml 🤔

@neilime
Copy link
Contributor Author

neilime commented Jun 27, 2023

@neilime I think we are missing an update to action.yml thinking

@jetersen Which omission are you referring to?

@jetersen
Copy link
Member

pre-release-identifier ? Would be useful to have in action as input option?

instead of only inside config.yml

@jetersen
Copy link
Member

jetersen commented Jun 28, 2023 •
edited

Reason I ask I could foresee people wanting the flexibility to determine the prerelease idenfier based on data and scripts in a GitHub action 🤔

@neilime
Copy link
Contributor Author

neilime commented Jun 28, 2023

Reason I ask I could foresee people wanting the flexibility to determine the prerelease idenfier based on data and scripts in a GitHub action thinking

Yes sure, I'm on it

@wadevries
Copy link

@neilime thanks for this change, it almost fixes my use case where I want to maintain separate draft releases for next release candidate and next final release. I've made a PR neilime#1 based on your fork.

@jaap3
Copy link

jaap3 commented Jul 18, 2023

Minor nit: the naming of pre-release-identifier is inconsistent with prerelease. Would be nice if pre-release/prerelease was spelled in a consistent manner.

@jaap3
Copy link

jaap3 commented Jul 19, 2023

I've added the pre-release-identifier input to our fork, leukeleu@e607143 feel free to cherry pick that commit.

@jetersen
Copy link
Member

Minor nit: the naming of pre-release-identifier is inconsistent with prerelease. Would be nice if pre-release/prerelease was spelled in a consistent manner.

I concur we should attempt to be consistent here.

@jetersen jetersen mentioned this pull request Jul 20, 2023
Open
@neilime
Copy link
Contributor Author

neilime commented Jul 21, 2023

Minor nit: the naming of pre-release-identifier is inconsistent with prerelease. Would be nice if pre-release/prerelease was spelled in a consistent manner.

I concur we should attempt to be consistent here.

FYI I've based the name to be consistent with include-pre-releases configuration key

@neilime neilime changed the title feat: add pre-release increment behavior feat: add prerelease increment behavior Jul 21, 2023
@neilime
Copy link
Contributor Author

neilime commented Jul 21, 2023

@jetersen I've made a separate commit to handle naming of "prerelease-identifier" and input

@jetersen jetersen added the type: feature New feature or request label Sep 25, 2023
@jetersen jetersen merged commit 576ba52 into release-drafter:master Sep 25, 2023
2 checks passed
@hosamshahin hosamshahin mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmchase justinmchase justinmchase approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neilime @jetersen @wadevries @jaap3 @justinmchase