Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release version to github action output #1300

Merged
merged 4 commits into from Jun 27, 2023
Merged

Add release version to github action output #1300

merged 4 commits into from Jun 27, 2023

Conversation

mehdihadeli
Copy link
Contributor

@mehdihadeli mehdihadeli commented Jan 16, 2023 •
edited by jetersen

fixes #1298

@mehdihadeli mehdihadeli mentioned this pull request Jan 16, 2023
Closed
@inomn
Copy link

inomn commented Feb 23, 2023

Hi! Any updates on this? :)

@mehdihadeli
Copy link
Contributor Author

I'm waiting for the review :)

@jetersen
Copy link
Member

Please see the contributions.md and follow the steps to generate dist

jetersen
jetersen approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for missing dist

@lemeurherve
Copy link

lemeurherve commented Feb 24, 2023 •
edited

(nit: "feat" is missing its "t" in the PR title)

@jetersen jetersen changed the title fea: add release version to github action output Add release version to github action output Feb 24, 2023
@jetersen jetersen added the type: feature New feature or request label Feb 24, 2023
@jetersen
Copy link
Member

@lemeurherve fixed 😉

@sebastienvermeille
Copy link

Hi guys, thank you for this PR I need exactly this :) waiting for the merge
Thank you

@paulo-hortelan
Copy link

Hi guys, is there any reason on why this hasn't been merged yet? That's exactly what i need

@jetersen
Copy link
Member

Stilling missing the dist to be updated.

@mehdihadeli
Copy link
Contributor Author

mehdihadeli commented Jun 22, 2023 •
edited

I did a yarn build according CONTRIBUTING.md for creating dist folder

@jetersen jetersen merged commit a04b609 into release-drafter:master Jun 27, 2023
2 checks passed
@jetersen
Copy link
Member

I'll release later today once I get home 😓

@mehdihadeli
Copy link
Contributor Author

Thanks for merging :)

@jetersen
Copy link
Member

@mehdihadeli I think we missed an update to action.yml
Would you mind sending a PR for the updated outputs? 🙇

@mehdihadeli
Copy link
Contributor Author

mehdihadeli commented Jun 27, 2023 •
edited

@jetersen sure, I will send a new pull request for that

@mehdihadeli mehdihadeli mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose RESOLVED_VERSION As output field for using in the other steps
6 participants
@mehdihadeli @inomn @jetersen @lemeurherve @sebastienvermeille @paulo-hortelan