Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): strip prefix before comparing version #1255

Merged
merged 1 commit into from Apr 13, 2023
Merged

fix(release): strip prefix before comparing version #1255

merged 1 commit into from Apr 13, 2023

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Oct 24, 2022

In documentation, it says

A known prefix used to filter release tags. For matching tags, this prefix is stripped before attempting to parse the version. Default: ""

However, while sorting version to retrieve the latest release, the prefix is taking into account and leads to sort regarding created_at, not semver

@neilime neilime force-pushed the fix/strip-prefix-before-comparing-version branch from 26471cd to d44cf88 Compare October 24, 2022 14:26
@DuMaM
Copy link

DuMaM commented Nov 23, 2022

Thanks for this PR,
Do you think it can resolve this issue?
#1269

@neilime
Copy link
Contributor Author

neilime commented Nov 23, 2022

@DuMaM Yes I think so

@DuMaM
Copy link

DuMaM commented Nov 23, 2022 •
edited

Hi @jetersen,
Sorry for pinging you, but this PR solves some pretty annoying issue of release drafter.
Could you take a look at it? 🙏

@neilime neilime force-pushed the fix/strip-prefix-before-comparing-version branch from d44cf88 to 4359101 Compare January 16, 2023 13:37
@neilime
Copy link
Contributor Author

neilime commented Jan 16, 2023

@jetersen need your approval to run the workflow, and your review. Thanks

@neilime neilime force-pushed the fix/strip-prefix-before-comparing-version branch from 4359101 to e198da4 Compare March 23, 2023 15:57
@neilime
Copy link
Contributor Author

neilime commented Mar 23, 2023

@jetersen 🆙 thanks

@jetersen jetersen added the type: bug Something isn't working label Apr 13, 2023
@jetersen jetersen merged commit b853a4c into release-drafter:master Apr 13, 2023
2 checks passed
@neilime neilime deleted the fix/strip-prefix-before-comparing-version branch April 13, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neilime @DuMaM @jetersen