Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty sure sadd should take a KeyT not an str for the key name #3189

Open
earonesty opened this issue Mar 19, 2024 · 0 comments
Open

pretty sure sadd should take a KeyT not an str for the key name #3189

earonesty opened this issue Mar 19, 2024 · 0 comments

Comments

@earonesty
Copy link

earonesty commented Mar 19, 2024

This function:

    def sadd(self, name: str, *values: FieldT) -> Union[Awaitable[int], int]:

differs from all other key functons in that the name is a "str", however there is no documentation that says it must be an str. all keys are "bytes safe" from the docs. should probably change all the set functions to KeyT.

Unless anyone disagrees, happy to put up a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant