Redundant async-timeout dependency in Redis 5.0.2

[Zaczero]

The async-timeout dependency was originally removed in #2602 due to its redundancy in modern Python.

It was re-added in Redis 5.0.2 (#3109) and appears to still be redundant for Python versions >= 3.11.3 (or 3.11).

The #3109 PR is the result of issue #3105.

The error message in #3105 (ModuleNotFoundError: No module named 'async-timeout') contains module name with a dash, instead of typical underscore. Hinting, that the error was thrown during the package installation and not runtime (otherwise it would be async_timeout).

It would be helpful if the original reporter of issue #3105 could provide more context from the error stack trace, instead of just the error message itself.

[Zaczero]

Attaching log from updating redis 5.0.1 to 5.0.2 on Python 3.12.2.

Updating dependencies
Resolving dependencies... (11.4s)

Package operations: 1 install, 4 updates, 0 removals

  • Updating python-dateutil (2.8.2 -> 2.9.0.post0)
  • Installing async-timeout (4.0.3)
  • Updating pydantic (2.6.2 -> 2.6.3)
  • Updating email-validator (2.1.0.post1 -> 2.1.1)
  • Updating redis (5.0.1 -> 5.0.2)

Writing lock file

[dvora-h]

@Zaczero Thanks for reporting this. I think you are right but I got a bit confused.
How do you think it need to be now? Do you want to open a PR to fix it?

[Zaczero]

Basically, as shown in this code search result, the async-timeout library is not imported on Python versions < 3.11.3.

As per my findings, I believe the #3105 had an installation issue and not runtime issue.
(because of module name with a dash)

Meaning, that this PR should be corrected:
The async-timeout>=4.0.3 should be replaced with async-timeout>=4.0.3; python_full_version<"3.11.3".

I hope this clears things a bit 🙂!

[dvora-h]

Yes, totally make sense, thank you!

Do you want to fix it or want me to do it?

[Zaczero]

I usually avoid doing such small PRs but suree #3177. Heads up, I did not complete the checklist.

[Zaczero]

Resolved

Package operations: 0 installs, 3 updates, 1 removal

  • Removing async-timeout (4.0.3)
  • Updating packaging (23.2 -> 24.0)
  • Updating redis (5.0.2 -> 5.0.3)
  • Updating uvicorn (0.27.1 -> 0.28.0)

Writing lock file