Cherry pick for v5.0.2 #3159

dvora-h · 2024-02-22T12:27:33Z

Pull Request check-list

Please make sure to review and check all of these items:

Do tests and lints pass with this change?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Is there an example added to the examples folder (if applicable)?
Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: d184230 <dubkov.a@skbkontur.ru>

…dition variable. (#2997)

* Close various objects created during asyncio tests * Fix resource leake in test_cwe_404.py Need to wait for individual handler tasks when shutting down server.

* first pass of geoshape index type * first attempt at test, but demonstrates the initial commit is broken * fix new field + fix tests * work on linter * more linter * try to mark test with correct fixture * fix linter

* Allow tracking/reporting and closing of "lost" connections. ConnectionPool keeps a WeakSet of in_use connections, allowing lost ones to be collected. Collection produces a warning and closes the underlying transport. * Add tests for the __del__ handlers of async Redis and Connection objects * capture expected warnings in the test * lint

Changed from `sleep_time: int = 0` to `sleep_time: float = 0.0` To avoid Pylance complaining: `Argument of type "float" cannot be assigned to parameter "sleep_time" of type "int" in function "run_in_thread" "float" is incompatible with "int"`

…2983 (#2984) Co-authored-by: Romain Fliedel <romain@oqee.tv>

codecov-commenter · 2024-02-25T10:40:43Z

Codecov Report

Attention: Patch coverage is 83.73494% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 91.32%. Comparing base (cc4bc1a) to head (6116c38).

Files	Patch %	Lines
tests/test_asyncio/test_connection.py	53.33%	14 Missing ⚠️
redis/_parsers/resp3.py	0.00%	5 Missing ⚠️
redis/asyncio/connection.py	86.20%	4 Missing ⚠️
tests/test_asyncio/test_retry.py	0.00%	3 Missing ⚠️
redis/asyncio/client.py	85.71%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              5.0    #3159      +/-   ##
==========================================
- Coverage   91.38%   91.32%   -0.06%     
==========================================
  Files         126      126              
  Lines       32608    32730     +122     
==========================================
+ Hits        29798    29892      +94     
- Misses       2810     2838      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.34.0 to 0.35.0. - [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases) - [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md) - [Commits](rojopolis/spellcheck-github-actions@0.34.0...0.35.0) --- updated-dependencies: - dependency-name: rojopolis/spellcheck-github-actions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…TS.ALTER (#3027)

* Fix parsing of ft.profile result * test

…2980)

…3012) Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

The typo cause hyperlinks to fail.

* Fix return types in JSONCommands class * Update CHANGES

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

* Adding lock_name to LockError * Adding lock_name to LockError --------- Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

* Fix objlen type hint * Update redis/commands/json/commands.py Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> * linters --------- Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

* Update cluster.py When Executing "n.write()" may generate some unknown errors(e.g. DataError), which could result in the connection not being released. * Update cluster.py * Update cluster.py release connection move to "try...finally" * Update cluster.py fix the linters * fix problems of code review

Co-authored-by: ahmedabdou14 <root@xps>

…nection raises an exception (#3133) Signed-off-by: zach.lee <zach.lee@sendbird.com>

Bumps [actions/stale](https://github.com/actions/stale) from 3 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v3...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Allow to control the minimum SSL version It's useful for applications that has strict security requirements. * Add tests for minimum SSL version The commit updates test_tcp_ssl_connect for both sync and async connections. Now it sets the minimum SSL version. The test is ran with both TLSv1.2 and TLSv1.3 (if supported). A new test case is test_tcp_ssl_version_mismatch. The test added for both sync and async connections. It uses TLS 1.3 on the client side, and TLS 1.2 on the server side. It expects a connection error. The test is skipped if TLS 1.3 is not supported. * Add example of using a minimum TLS version

The `get_message()` method in asyncio PubSub has a `timeout` argument that defaults to 0.0, causing it to immediately return. This can cause high CPU usage with the given code example and should not be recommended. By setting `timeout=None`, it works with much more efficient resource usage.

Exception ignored in: <function Redis.__del__ at ...> Traceback .... TypeError: 'NoneType' object cannot be interpreted as an integer. This happens when closing the connection within a spawned Process (multiprocess).

* Fix retry logic for pubsub and pipeline Extend the fix from bea7299 to apply to pipeline and pubsub as well. Fixes #2973 * fix isort --------- Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

dependabot bot and others added 12 commits February 22, 2024 14:24

Bump actions/checkout from 3 to 4 (#2969)

db03189

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump rojopolis/spellcheck-github-actions from 0.33.1 to 0.34.0 (#2970)

e7cc3bb

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix type hint (#2963)

0172ded

Co-authored-by: d184230 <dubkov.a@skbkontur.ru>

Don't perform blocking connect inside the BlockingConnectionQueue Con…

565171c

…dition variable. (#2997)

Creating CODEOWNERS for the examples (#2993)

697da37

Close various objects created during asyncio tests (#3005)

9970fb4

* Close various objects created during asyncio tests * Fix resource leake in test_cwe_404.py Need to wait for individual handler tasks when shutting down server.

Linking to Redis resources (#3006)

194d710

Add GEOSHAPE field type for index creation of RediSearch (#2957)

b5e8e55

* first pass of geoshape index type * first attempt at test, but demonstrates the initial commit is broken * fix new field + fix tests * work on linter * more linter * try to mark test with correct fixture * fix linter

Fix BlockingConnectionPool.from_url parsing of timeout in query args #…

e2127e4

…2983 (#2984) Co-authored-by: Romain Fliedel <romain@oqee.tv>

Fix parsing resp3 dicts (#2982)

45e858a

dvora-h changed the title ~~Bump actions/checkout from 3 to 4 (#2969)~~ Cherry pick for v5.0.2 Feb 25, 2024

AniketP04 and others added 16 commits February 25, 2024 14:20

Update ocsp.py (#3022)

63b562f

Use disable_decoding in async read_response. (#3042)

9402c30

Add "sum" to DUPLICATE_POLICY documentation of TS.CREATE, TS.ADD and …

ab82697

…TS.ALTER (#3027)

Update advanced_features.rst (#3019)

f2fa734

Fix typos. (#3016)

c1a881e

Fix parsing of FT.PROFILE result (#3063)

7c13191

* Fix parsing of ft.profile result * test

Make the connection callback methods public again, add documentation (#…

3f4f5e3

…2980)

Fix reported version of deprecations in asyncio.client (#2968)

f29a7d7

Allow the parsing of the asking command to forward original options (#…

7573448

…3012) Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

Fix Specifying Target Nodes broken hyperlink (#3072)

b7dbb7e

The typo cause hyperlinks to fail.

Fix return types in json commands (#3071)

ce6d7b4

* Fix return types in JSONCommands class * Update CHANGES

fix acl_genpass with bits (#3062)

6116c38

chayim and others added 19 commits February 25, 2024 15:23

Always sending codecov (#3101)

813187e

filter commits for main branch (#3036)

5c94a95

fix(docs): organize cluster mode part of lua scripting (#3073)

7b1965a

Fix typing for HashCommand.hdel (#3029)

d63ba59

Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

Adding lock_name to LockError (#3023)

33450d9

* Adding lock_name to LockError * Adding lock_name to LockError --------- Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

Fix objlen type hint (#2966)

a32b513

* Fix objlen type hint * Update redis/commands/json/commands.py Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com> * linters --------- Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

Fix type hint of arbitrary argument lists (#2908)

a0b820d

Fix: hset unexpectedly mutates the list passed to items (#3103)

316667e

Add modules support to async RedisCluster (#3115)

8e5020e

Fix grammer in BlockingConnectionPool class documentation (#3120)

3f23fff

Co-authored-by: ahmedabdou14 <root@xps>

release already acquired connections on ClusterPipeline, when get_con…

101a28d

…nection raises an exception (#3133) Signed-off-by: zach.lee <zach.lee@sendbird.com>

Revert stale isuue version update (#3142)

b3f4710

Update connection.py (#3149)

7fa3bd4

Exception ignored in: <function Redis.__del__ at ...> Traceback .... TypeError: 'NoneType' object cannot be interpreted as an integer. This happens when closing the connection within a spawned Process (multiprocess).

Fix retry logic for pubsub and pipeline (#3134)

5dff4ef

* Fix retry logic for pubsub and pipeline Extend the fix from bea7299 to apply to pipeline and pubsub as well. Fixes #2973 * fix isort --------- Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>

dvora-h marked this pull request as ready for review February 25, 2024 14:09

dvora-h requested a review from a team February 25, 2024 17:14

Update install_requires (#3109)

3b18dc0

chayim approved these changes Feb 26, 2024

View reviewed changes

dvora-h merged commit 911aa37 into 5.0 Feb 26, 2024
53 of 54 checks passed

dvora-h deleted the 502-cherry-pick branch February 26, 2024 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cherry pick for v5.0.2 #3159

Cherry pick for v5.0.2 #3159

dvora-h commented Feb 22, 2024

codecov-commenter commented Feb 25, 2024 •

edited

Cherry pick for v5.0.2 #3159

Cherry pick for v5.0.2 #3159

Conversation

dvora-h commented Feb 22, 2024

Pull Request check-list

Description of change

codecov-commenter commented Feb 25, 2024 • edited

Codecov Report

codecov-commenter commented Feb 25, 2024 •

edited