Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 introduces CLIENT SETINFO which is not compatible with Redis < 7.2 #3085

Closed
earthgecko opened this issue Dec 22, 2023 · 2 comments
Closed

Comments

@earthgecko
Copy link
Contributor

Version:
redis-stack-server: redis-stack-server-6.2.6-v7.rhel8.x86_64.tar.gz
redis_version:6.2.12
redis-py: 5.0.1

Platform: Python 3.8.17 on CentOS Stream 8

Description:

With the introduction of CLIENT SETINFO in connection.py in 5.0.0 (Add support for CLIENT SETINFO (#2857)), the INFO commandstats now reports cmdstats_client which now increments failed_calls on every connection.

cmdstat_client:calls=114604,usec=552723,usec_per_call=4.82,rejected_calls=0,failed_calls=114604

SETINFO was only added in Redis 7.2 therefore 5.0.0 will consider any connection on a Redis < 7.2 as a failed_call.

It seems to have no impact on Redis or the functionality whatsoever, other than incrementing the failed_calls counter and it happens on every connect. Although it does have an impact on telemetry and monitoring.

A very big thanks to Steve L (admin on Redis discord) for the very helpful assistance in identifying the cause of the issue here.

earthgecko added a commit to earthgecko/redis-py that referenced this issue Dec 22, 2023
@dvora-h
Copy link
Collaborator

dvora-h commented Jan 1, 2024

@earthgecko If you want to skip CLIENT SETINFO you can set the library name and version to None (here, it sends the command only if the information exist, and yes, by default it exist)

r = redis.Redis(lib_name=None, lib_version=None)

@earthgecko
Copy link
Contributor Author

Thanks for the info @dvora-h 👍 I shall implement those additional parameters

@dvora-h dvora-h closed this as completed Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants