Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_scorer (search) #2920

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix test_scorer (search) #2920

merged 1 commit into from
Aug 31, 2023

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 29, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Sorry, something went wrong.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 29, 2023
@dvora-h dvora-h requested a review from chayim August 29, 2023 23:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.37% 🎉

Comparison is base (28cc65c) 90.91% compared to head (d78cdee) 91.28%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
+ Coverage   90.91%   91.28%   +0.37%     
==========================================
  Files         126      126              
  Lines       32384    32391       +7     
==========================================
+ Hits        29441    29569     +128     
+ Misses       2943     2822     -121     
Files Changed Coverage Δ
tests/test_asyncio/test_search.py 69.53% <50.00%> (ø)
tests/test_search.py 73.38% <50.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h dvora-h merged commit e3de026 into redis:master Aug 31, 2023
zach-iee pushed a commit to sendbird/redis-py that referenced this pull request Sep 1, 2023
zach-iee pushed a commit to sendbird/redis-py that referenced this pull request Sep 1, 2023
zach-iee pushed a commit to sendbird/redis-py that referenced this pull request Sep 1, 2023
zach-iee added a commit to sendbird/redis-py that referenced this pull request Sep 4, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
zach-iee added a commit to sendbird/redis-py that referenced this pull request Sep 14, 2023
Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants