Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.3.5 #2469

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Version 4.3.5 #2469

merged 1 commit into from
Nov 22, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 21, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim requested a review from dvora-h November 21, 2022 15:58
@codecov-commenter
Copy link

Codecov Report

Base: 85.91% // Head: 85.92% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7d0e5ce) compared to base (72f90c2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.3    #2469      +/-   ##
==========================================
+ Coverage   85.91%   85.92%   +0.01%     
==========================================
  Files         110      110              
  Lines       28489    28489              
==========================================
+ Hits        24475    24478       +3     
+ Misses       4014     4011       -3     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
redis/asyncio/connection.py 83.99% <0.00%> (+0.11%) ⬆️
tests/test_cluster.py 97.08% <0.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chayim chayim merged commit 54a1dce into 4.3 Nov 22, 2022
@chayim chayim deleted the ck435 branch November 22, 2022 07:15
@utkarshgupta137
Copy link
Contributor

Thanks @chayim @dvora-h!
I hate to pester you again, but since #2217 was not included in this release, I request you expedite 4.4 as much as possible.

@noorul
Copy link

noorul commented Nov 23, 2022

@utkarshgupta137 How did you work around connection settings issue which is fixed in #2217 ?

@utkarshgupta137
Copy link
Contributor

@utkarshgupta137 How did you work around connection settings issue which is fixed in #2217 ?

That change is not included in 4.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants