Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark TOPK.COUNT as deprecated #2363

Merged
merged 2 commits into from
Sep 4, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 29, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2351

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #2363 (c9a16c8) into master (ab5d407) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
- Coverage   92.21%   92.19%   -0.02%     
==========================================
  Files         111      111              
  Lines       28782    28788       +6     
==========================================
+ Hits        26540    26542       +2     
- Misses       2242     2246       +4     
Impacted Files Coverage Δ
redis/commands/bf/commands.py 98.39% <100.00%> (+0.01%) ⬆️
tests/test_asyncio/test_bloom.py 99.58% <100.00%> (+<0.01%) ⬆️
tests/test_bloom.py 99.60% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 96.85% <0.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h merged commit 744cb09 into redis:master Sep 4, 2022
dvora-h added a commit that referenced this pull request Nov 21, 2022
* deprecate

* linters
kosuke-zhang pushed a commit to uup-saas/redis-py that referenced this pull request Dec 4, 2022
@dvora-h dvora-h deleted the deprecate-topk.count branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to mark TOPK.COUNT as deprecated, for Bloom 2.4.0
3 participants