Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TimeSeries range aggregation (twa) tests #2358

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 25, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Aug 25, 2022
@dvora-h dvora-h requested a review from chayim August 25, 2022 13:09
@chayim chayim changed the title Fix twa aggregation test Fix TimeSeries range aggregation (twa) tests Aug 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #2358 (a9b7b63) into master (b5ebada) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2358      +/-   ##
==========================================
- Coverage   92.21%   92.20%   -0.01%     
==========================================
  Files         111      111              
  Lines       28781    28782       +1     
==========================================
- Hits        26539    26538       -1     
- Misses       2242     2244       +2     
Impacted Files Coverage Δ
tests/test_asyncio/test_timeseries.py 100.00% <100.00%> (ø)
tests/test_timeseries.py 100.00% <100.00%> (ø)
tests/test_asyncio/test_search.py 98.43% <0.00%> (-0.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dvora-h dvora-h merged commit ab5d407 into redis:master Aug 25, 2022
@kristjanvalur
Copy link
Contributor

kristjanvalur commented Aug 25, 2022

You should probably look at your PRs more closely, see #2357
It's frustrating trying to help when contributions are overlooked.
Anyway, I think you should probably have taken my approach, since asserting on 10th digit floating point value from a possibly fickle server math solution isn't particularly robust. You're testing the Python api, not the algorithm that the server uses to compute.

dvora-h added a commit that referenced this pull request Nov 21, 2022
kosuke-zhang pushed a commit to uup-saas/redis-py that referenced this pull request Dec 4, 2022
@dvora-h dvora-h deleted the timeseries-twa branch June 18, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants