Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2665 - handle errors in multi/pipeline replies #2666

Merged
merged 5 commits into from Dec 18, 2023

Conversation

leibale
Copy link
Collaborator

@leibale leibale commented Dec 5, 2023

fix #2665

@LiraNuna wanna test it? :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6d2064) 95.51% compared to head (69d9557) 95.68%.

❗ Current head 69d9557 differs from pull request most recent head e9d919e. Consider uploading reports for the commit e9d919e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2666      +/-   ##
==========================================
+ Coverage   95.51%   95.68%   +0.16%     
==========================================
  Files         462      462              
  Lines        4617     4631      +14     
  Branches      536      538       +2     
==========================================
+ Hits         4410     4431      +21     
+ Misses        131      127       -4     
+ Partials       76       73       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leibale added a commit that referenced this pull request Dec 5, 2023
Copy link
Contributor

@guyroyse guyroyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@guyroyse guyroyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leibale leibale merged commit f4680f0 into redis:master Dec 18, 2023
12 checks passed
@leibale leibale deleted the fix-2665 branch December 18, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MULTI does not handle commands "runtime" errors
4 participants