Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pingInterval option delays graceful exit #2524

Closed
jorenvandeweyer opened this issue Jun 5, 2023 · 0 comments · Fixed by #2525
Closed

pingInterval option delays graceful exit #2524

jorenvandeweyer opened this issue Jun 5, 2023 · 0 comments · Fixed by #2525
Labels
Bug

Comments

@jorenvandeweyer
Copy link
Contributor

Description

Using pingInterval in the client options delays a graceful exit.

Node.js Version

v20

Redis Server Version

v7

Node Redis Version

4.6.6

Platform

macos

Logs

No response
jorenvandeweyer added a commit to jorenvandeweyer/node-redis that referenced this issue Jun 5, 2023
@jorenvandeweyer
fixes redis#2524
36dbd1e
@jorenvandeweyer jorenvandeweyer mentioned this issue Jun 5, 2023
Merged
3 tasks
leibale added a commit to leibale/node-redis that referenced this issue Jun 7, 2023
@leibale
ref redis#2524 - clear pingInterval timeout on close
b01f177
leibale added a commit that referenced this issue Aug 23, 2023
@jorenvandeweyer @leibale
fixes #2524 delaying graceful exit while pingInterval is set (#2525)
bc8abd5 
* fixes #2524

* `clearTimeout` in `disconnect` too

---------

Co-authored-by: Leibale Eidelman <me@leibale.com>
@jorenvandeweyer jorenvandeweyer mentioned this issue Aug 28, 2023
Closed
@leibale leibale mentioned this issue Sep 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #2524 delaying graceful exit while pingInterval is set jorenvandeweyer/node-redis
1 participant
@jorenvandeweyer