feat: add support for rediss protocol in url #1282
Merged
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just wanted to start on working on the exact same thing. Some PaaS providers (e.g. Azure) default to make redis available through a TLS socket. Alongside the clients @calebboyd already mentioned, Predis (PHP) does the same. Would be cool to see this small change merged. |
BridgeAR
reviewed
Jan 9, 2018
README.md
Outdated
| @@ -216,7 +216,7 @@ using unix sockets if possible to increase throughput. | |||
| | host | 127.0.0.1 | IP address of the Redis server | | |||
| | port | 6379 | Port of the Redis server | | |||
| | path | null | The UNIX socket string of the Redis server | | |||
| | url | null | The URL of the Redis server. Format: `[redis:]//[[user][:password@]][host][:port][/db-number][?db=db-number[&password=bar[&option=value]]]` (More info avaliable at [IANA](http://www.iana.org/assignments/uri-schemes/prov/redis)). | | |||
| | url | null | The URL of the Redis server. Format: `[redis:][rediss:]//[[user][:password@]][host][:port][/db-number][?db=db-number[&password=bar[&option=value]]]` (More info avaliable at [IANA](http://www.iana.org/assignments/uri-schemes/prov/redis)). | | |||
There was a problem hiding this comment.
Can you please change this to the following?
[redis[s]:]//[[user][:password@]][host][:port][/db-number][?db=db-number[&password=bar[&option=value]]]
Right now the syntax would be wrong as it would actually "allow" redis:rediss://....
lib/createClient.js
Outdated
| options.tls = options.tls || {}; | ||
| } else { | ||
| console.warn('node_redis: WARNING: You passed "' + parsed.protocol.substring(0, parsed.protocol.length - 1) + '" as protocol instead of the "redis" protocol!'); | ||
| } |
There was a problem hiding this comment.
Could you please change this to the following:
if (parsed.protocol) {
if (parsed.protocol === 'rediss:') {
options.tls = ...
} else if (parsed.protocol !== 'redis:') {
console.warn('...')
}
}
test/tls.spec.js
Outdated
| @@ -108,6 +108,29 @@ describe('TLS connection tests', function () { | |||
| client.get('foo', helper.isString('bar', done)); | |||
| }); | |||
|
|
|||
| describe('using rediss as url protocol', function (done) { | |||
| var tls = require('tls') | |||
There was a problem hiding this comment.
Please move the require to the top of the file.
|
@BridgeAR updated! |
BridgeAR
approved these changes
Jan 9, 2018
epatters
added a commit
to epatters/datascienceontology-backend
that referenced
this pull request
Oct 18, 2018
Use master version of Node Redis client for now, because TLS support is not yet officially released: redis/node-redis#1268 redis/node-redis#1282
epatters
added a commit
to epatters/datascienceontology-backend
that referenced
this pull request
Dec 1, 2019
Use master version of Node Redis client for now, because TLS support is not yet officially released: redis/node-redis#1268 redis/node-redis#1282
epatters
added a commit
to epatters/datascienceontology-backend
that referenced
this pull request
Dec 1, 2019
Use master version of Node Redis client for now, because TLS support is not yet officially released: redis/node-redis#1268 redis/node-redis#1282
|
@BridgeAR do you have any plans to publish a new version with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to pass
redissas the protocol for aredis_urlThis functionality is common in several other redis clients (redis-py, lettuce, Jedis etc)
It is the equivalent of doing
It is useful when the the host is signed by a global CA, and no advanced (self signed etc) configuration is required.