Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support publishing of long-lived JFR events to the EventBus #2824

Open
mp911de opened this issue Apr 9, 2024 Discussed in #2809 · 0 comments
Open

Support publishing of long-lived JFR events to the EventBus #2824

mp911de opened this issue Apr 9, 2024 Discussed in #2809 · 0 comments
Labels
type: enhancement A general enhancement

Comments

@mp911de
Copy link
Collaborator

mp911de commented Apr 9, 2024

Discussed in #2809

Originally posted by rkeely April 2, 2024
I would like to know the reason of only publishing TopologyRefreshEvent to EventRecorder as implemented here. My app subscribe to all events on event bus but does not receive any TopologyRefreshEvent so I assume the current implementation of EventRecorder does not publish to event bus but only JFR, is that correct? Could we consider dual-publishing it to event bus as well? I am happy to create a PR if this idea sounds good.

Here are my reasons why we want this:

  • People normally do not setup recording for JFR in production. We love out of box support without extra effort :D
  • For Redis cluster with large number of nodes and with large number of clients, the toll on topology refresh will be heavy for both side. As application owner, we would like to monitor the occurrence of TopologyRefreshEvent and make sure there is no un-wanted refresh. I know we can control the refresh periods but unexpected resonation from many clients could happen (e.g. when we scale out our client fleet). Currently we have to use the number connection events to infer the refresh. Being able to easily subscribe to the event could give an concrete answer.
@mp911de mp911de added the type: enhancement A general enhancement label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant