Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle network error on SETINFO #3295

Merged
merged 6 commits into from
Mar 19, 2025

Conversation

ndyakov
Copy link
Collaborator

@ndyakov ndyakov commented Mar 10, 2025

  • handle non-redis errors on setinfo in connInit
  • introduce new (duplicate) flag DisableIdentity for DisableIndentity to work side by side, addressing the misspelled flag, prior to v10

both options will work before V10. In v10 we will drop DisableIndentity
@ndyakov ndyakov force-pushed the ndyakov/fix-handle-error-on-initConn branch from 954af1e to b817963 Compare March 11, 2025 11:26
@ndyakov ndyakov marked this pull request as ready for review March 19, 2025 15:11
@ndyakov ndyakov requested a review from vladvildanov March 19, 2025 15:13
@ndyakov ndyakov self-assigned this Mar 19, 2025
@ndyakov ndyakov merged commit d236865 into master Mar 19, 2025
16 checks passed
ndyakov added a commit that referenced this pull request Mar 19, 2025
* fix: handle network error on SETINFO

This fix addresses potential out of order responses as described in `CVE-2025-29923`

* fix: deprecate DisableIndentity and introduce DisableIdentity

Both options will work before V10. In v10 DisableIndentity will be dropped. The preferred flag to use is `DisableIdentity`.
ndyakov added a commit that referenced this pull request Mar 20, 2025
* fix: handle network error on SETINFO

This fix addresses potential out of order responses as described in `CVE-2025-29923`

* fix: deprecate DisableIndentity and introduce DisableIdentity

Both options will work before V10. In v10 DisableIndentity will be dropped. The preferred flag to use is `DisableIdentity`.
ndyakov added a commit that referenced this pull request Mar 20, 2025
* fix: handle network error on SETINFO

This fix addresses potential out of order responses as described in `CVE-2025-29923`

* fix: deprecate DisableIndentity and introduce DisableIdentity

Both options will work before V10. In v10 DisableIndentity will be dropped. The preferred flag to use is `DisableIdentity`.
ndyakov added a commit that referenced this pull request Mar 20, 2025
* fix: handle network error on SETINFO

This fix addresses potential out of order responses as described in `CVE-2025-29923`

* fix: deprecate DisableIndentity and introduce DisableIdentity

Both options will work before V10. In v10 DisableIndentity will be dropped. The preferred flag to use is `DisableIdentity`.
ndyakov added a commit that referenced this pull request Mar 20, 2025
* fix: handle network error on SETINFO

This fix addresses potential out of order responses as described in `CVE-2025-29923`

* fix: deprecate DisableIndentity and introduce DisableIdentity

Both options will work before V10. In v10 DisableIndentity will be dropped. The preferred flag to use is `DisableIdentity`.
ndyakov added a commit that referenced this pull request Mar 20, 2025
* fix: handle network error on SETINFO

This fix addresses potential out of order responses as described in `CVE-2025-29923`

* fix: deprecate DisableIndentity and introduce DisableIdentity

Both options will work before V10. In v10 DisableIndentity will be dropped. The preferred flag to use is `DisableIdentity`.
@ndyakov ndyakov deleted the ndyakov/fix-handle-error-on-initConn branch March 21, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants