Update lib.rs #823
Merged
Update lib.rs #823
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
added a commit
to barshaul/redis-rs
that referenced
this pull request
Jul 11, 2024
* Update CD in order to publish packages, in branch v0.1 (redis-rs#800) * Update CD with new arguments. * Update NPM package name to account for AWS org. --------- Co-authored-by: nihohit <nihohit@gmail.com> * Publish public packages to npm. (redis-rs#802) Co-authored-by: nihohit <nihohit@gmail.com> * Fix binary packages versions. (redis-rs#801) Co-authored-by: nihohit <nihohit@gmail.com> * run `npm login` before publishing * set config instead of using interactive login. * fix config set * fix registery address * split cd to separate workflows. This will allow us to find/debug issues concurrently, instead of having node block the python deployments. * Update workflow names. * Disable python CD. It ran successfully, no need for it to run again. * Revert "Disable python CD." This reverts commit f897121875bf2a8335d755d5bd7c72cd66d8d8f7. * Make Node & Python's READMEs better for package managers. (redis-rs#823) Package managers show the READMEs as the main text describes the package. Thus, the README should contain the header explaining what the project is. Additionally, removed the developer-oriented build explanation, and moved it to the DEVELOPER section, with a matching link. Co-authored-by: nihohit <nihohit@gmail.com> * Disable publishing python & npm sub-packages. * another attempt * Update package.json Update the optional dependencies * Update pypi-cd.yml Do not publish on older version this code should be removed * Update README.md add @aws prefix tot the import * Remove publish blockers from CD scripts. * Fix binary packages versions. * Fix pypi-cd to build macOS wheels also for py3.8 and py3.9 * Remove unnecessary parts. * Remvoe npm set. --------- Co-authored-by: Shachar Langbeheim <98546660+shachlanAmazon@users.noreply.github.com> Co-authored-by: asafpamzn <97948347+asafpamzn@users.noreply.github.com> Co-authored-by: barshaul <barshaul@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822