Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more idiomatic query and index creation with new version of redis-py #2

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Implement more idiomatic query and index creation with new version of redis-py #2

wants to merge 3 commits into from

Conversation

simonprickett
Copy link
Contributor

This PR updates the code to use the inteface as defined in the following redis-py PR:

redis/redis-py#2957

Once this is merged and released, I'll need to update requirements.txt on this branch to pick up the latest redis-py release before merging it. Until then, merging is blocked.

This closes #1

@simonprickett simonprickett added the enhancement New feature or request label Oct 9, 2023
@simonprickett simonprickett self-assigned this Oct 9, 2023
@simonprickett simonprickett changed the title Redis py updated for geoshape Implement more idiomatic query and index creation with new version of redis-py Oct 9, 2023
@simonprickett simonprickett mentioned this pull request Oct 9, 2023
Merged
6 tasks
@simonprickett
Copy link
Contributor Author

This needs redis-py 5.1.0 to be released. Draft release here: https://github.com/redis/redis-py/releases/tag/untagged-addc0fc2d47b1bd864b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simonprickett simonprickett

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to using more idiomatic redis-py interface for polygon search when available.
1 participant
@simonprickett