Show more context for ShellCheck defects and fixes in console output 💾 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 4 4
Lines 277 277
=======================================
Hits 235 235
Misses 42 42
|
When using --format=json1, the csgrep output is missing defect position. Reported in: csutils/csdiff#138 Once fixed, this commit should be reverted
jamacku
force-pushed
the
csgrep-context
branch
2 times, most recently
from
00a47fb
to
6bd1f03
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,6 +1,9 @@ | |||
| # shellcheck shell=bash | |||
| # SPDX-License-Identifier: GPL-3.0-or-later | |||
|
|
|||
| # shellcheck source=summary.sh | |||
| . "${SCRIPT_DIR=}summary.sh" | |||
Check warning
Code scanning / shellcheck
Not following: summary.sh: openBinaryFile: does not exist (No such file or directory) Warning
jamacku
force-pushed
the
csgrep-context
branch
9 times, most recently
from
dc24761
to
0899d12
Compare
Show more context for ShellCheck defects and fixes in console output. Using the `csgrep --embed-context` option allows us to show a part of the code in which a defect is reported. This is much more user-friendly than the current plain GCC output format. This commit also fixes issues with statistics calculations. Related to: redhat-plumbers-in-action#88
jamacku
force-pushed
the
csgrep-context
branch
from
0899d12
to
070cb3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes: