Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: do not escape # and ! in patterns 🍏 #220

Merged
merged 1 commit into from Mar 22, 2023
Merged

grep: do not escape # and ! in patterns 🍏 #220

merged 1 commit into from Mar 22, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Mar 22, 2023

Related to csutils/csmock#101

@jamacku jamacku requested a review from lzaoral March 22, 2023 14:59
@jamacku jamacku self-assigned this Mar 22, 2023
@mergify mergify bot added the source label Mar 22, 2023
lzaoral
lzaoral approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We couldn't uncover this sooner because grep was executed with --quiet which suppresses any output.

@mergify mergify bot merged commit c5455cf into redhat-plumbers-in-action:main Mar 22, 2023
6 of 7 checks passed
@jamacku jamacku deleted the fix-grep-escape branch March 22, 2023 15:03
@jamacku jamacku mentioned this pull request Mar 23, 2023
Merged
@jamacku jamacku added this to the v4.1.0 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzaoral lzaoral lzaoral approved these changes

Assignees

@jamacku jamacku

Labels
source type: bugfix
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamacku @lzaoral