Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add indentation when parsing example as string #890

Merged
merged 3 commits into from Jun 25, 2023
Merged

fix: add indentation when parsing example as string #890

merged 3 commits into from Jun 25, 2023

Conversation

AceTheCreator
Copy link
Contributor

What does this PR do?

Enhanced how examples are being parsed as a plain string

What issues does this PR fix or reference?

#889

@AceTheCreator
Update yamlHover.ts
49a7b1e 
Enhanced how examples are being parsed as a plain string 

fixes redhat-developer#889
@coveralls
Copy link

coveralls commented Jun 2, 2023 •
edited

Coverage Status

coverage: 83.762%. remained the same when pulling 14a6ac2 on AceTheCreator:patch-1 into b2b129a on redhat-developer:main.

@AceTheCreator
Copy link
Contributor Author

Hey, @msivasubramaniaan, can you look into this PR?

gorkem
gorkem approved these changes Jun 25, 2023
View reviewed changes
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you for your contribution

msivasubramaniaan
msivasubramaniaan approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution @AceTheCreator

@msivasubramaniaan msivasubramaniaan merged commit bddfbff into redhat-developer:main Jun 25, 2023
4 checks passed
@AceTheCreator
Copy link
Contributor Author

@msivasubramaniaan @gorkem any idea when the next release will happen?

@msivasubramaniaan
Copy link
Contributor

@AceTheCreator you can expect the release on next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem gorkem approved these changes

@msivasubramaniaan msivasubramaniaan msivasubramaniaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AceTheCreator @coveralls @msivasubramaniaan @gorkem