Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-1108: Support for VS Code 1.86.0 #1114

Merged
merged 2 commits into from
Feb 9, 2024
Merged

issue-1108: Support for VS Code 1.86.0 #1114

merged 2 commits into from
Feb 9, 2024

Conversation

djelinek
Copy link
Collaborator

@djelinek djelinek commented Feb 7, 2024

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek linked an issue Feb 7, 2024 that may be closed by this pull request
[🚀 Request] Support for VS Code 1.86.x #1108
Closed
@djelinek djelinek force-pushed the issue-1108 branch 5 times, most recently from a77de02 to d3f59ca Compare February 7, 2024 22:44
@djelinek
issue-1108: Support for VS Code 1.86.0
ae34ad9 
Signed-off-by: Dominik Jelinek <djelinek@redhat.com>
@djelinek djelinek force-pushed the issue-1108 branch 4 times, most recently from 00a3720 to 04acaf4 Compare February 8, 2024 21:31
@c3-WesleyPickering @djelinek
issue-1071: Fix downloading chromedriver version > 114
542c3ff 
Signed-off-by: Dominik Jelinek <djelinek@redhat.com>

Based on initial work of Wesley pickering <wesley.pickering@c3.ai>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek mentioned this pull request Feb 9, 2024
Closed
9 tasks
@djelinek djelinek marked this pull request as ready for review February 9, 2024 10:05
@djelinek djelinek linked an issue Feb 9, 2024 that may be closed by this pull request
[🚫 Bug] Unable to download chromedriver for ReleaseQuality.Insider #1071
Closed
@djelinek djelinek merged commit ed4e082 into redhat-developer:main Feb 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@djelinek @c3-WesleyPickering