Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/node20 #93

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

Eusebiotrigo
Copy link
Contributor

Update action to use node 20.
Updates all workflows to use newer action versions and also the environment they run on, from ubuntu 20.04 to ubuntu 22.04

Description

Fix deprecation warning from GitHub actions when running this action.

Related Issue(s)

#92

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

Make the action run on node20, not in node16

@Eusebiotrigo
Copy link
Contributor Author

Eusebiotrigo commented Feb 5, 2024

Tagging @divyansh42 to check if he's still active in this repo.
And @der-eismann

@der-eismann
Copy link
Contributor

Hey @Eusebiotrigo! Not much I can do, this and buildah-build seem to be dead at this point. My PR over there got merged, but not released yet. We maintain our own forks, but we don't have the capability to run them as proper open source projects.

@Eusebiotrigo
Copy link
Contributor Author

Thanks @der-eismann. It would be time to create our own forks or look for alternatives.

Copy link
Member

@divyansh42 divyansh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Eusebiotrigo 👍

@divyansh42
Copy link
Member

Apologies for the delay. We were not able to look at these due to other multiple priorities.

@divyansh42
Copy link
Member

@Eusebiotrigo could you please rebase your PR? I did some changes.

@divyansh42 divyansh42 merged commit 0fa2dca into redhat-actions:main Mar 5, 2024
@divyansh42
Copy link
Member

Okay, I merged that as it is.

@Eusebiotrigo Eusebiotrigo deleted the support/node20 branch March 6, 2024 19:29
@divyansh42
Copy link
Member

The latest change has been released with versions v2 and v2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants