Rector fixes formatting for php template syntax

[renakdup]

Bug Report

Subject	Details
Rector version	e.g. v1.0.0 (invoke vendor/bin/rector --version)

I found that Rector tries to fix formatting of PHP Template syntax

Minimal PHP Code Causing Issue

<div class="cocktails-carousel__wrapper animated-block js-swiper-wrapper">
	<div class="cocktails-carousel__info cocktails-carousel__placeholder">
		<?php if ( ! empty( $secondary_title ) ) : ?>
			<h4 class="animated-heading invisible-content"><?php echo $secondary_title; //phpcs:ignore  ?></h4>
		<?php endif; ?>

		<?php if ( ! empty( $title_carousel ) ) : ?>
			<h2 class="animated-heading invisible-content <?php echo esc_attr( $title_class ); ?>"
				><?php echo $title_carousel //phpcs:ignore ?></h2>
		<?php endif; ?>

Expected Behaviour

Expected that Rector would not change it, but now I got next

<div class="cocktails-carousel__wrapper animated-block js-swiper-wrapper">
	<div class="cocktails-carousel__info cocktails-carousel__placeholder">
		<?php if ( ! empty( $secondary_title ) ) : ?>
			<h4 class="animated-heading invisible-content"><?php echo $secondary_title; //phpcs:ignore  ?></h4>
<?php endif; ?>

		<?php if ( ! empty( $title_carousel ) ) : ?>
			<h2 class="animated-heading invisible-content <?php echo esc_attr( $title_class ); ?>"
				><?php echo $title_carousel //phpcs:ignore ?></h2>
		<?php endif; ?>

[samsonasik]

That's known drawback, see https://github.com/rectorphp/rector?tab=readme-ov-file#known-drawbacks

I tested on https://getrector.com/demo/f2f6777c-c146-4309-b3d4-326f525cc702 and seems no change, It may be due to different tab vs space usage on your own.

you can use coding standard tool after rector to handle that.

[renakdup]

I could catch it on another example https://getrector.com/demo/2cf6850a-d099-4fb9-801a-6e22aa793480
.
If we remove the namespace it works fine.

[samsonasik]

That may can be improved by regex check like in:

• fix: Strip left spaces from opening tags when comparing output for changes rector-src#5701

Feel free to provide improvement PR, otherwise, you can rely to coding standard tool or skip the file https://getrector.com/documentation/ignoring-rules-or-paths

[renakdup]

May we open this issue, so that I or somebody else provides this fix in the future? That people see that such kind of problems exist?

[samsonasik]

The space formatting is already stated as known drawback, not part of "bug", and that is fine as is, and may require refactor once we use php-parser v5.

For templating file, I suggest to run once + fix coding style, then skip at rector.php :)

You can create a PR improvement when you have a chance :)