Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Upgrade GitHub Action azure/login #2065

Closed
SimonYansenZhao opened this issue Feb 20, 2024 · 2 comments
Closed

[BUG] Upgrade GitHub Action azure/login #2065

SimonYansenZhao opened this issue Feb 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@SimonYansenZhao
Copy link
Collaborator

SimonYansenZhao commented Feb 20, 2024

Description

This bug report is just a reminder that azure/login should be upgraded once a newer version that resolves those issues is released in the future.

azure/login is a GitHub Action used in the testing of Recommenders:

- name: Log in to Azure
uses: azure/login@v1
with:
creds: ${{inputs.AZUREML_TEST_CREDENTIALS}}

However, recent testing logs warn about the Node.js 16 used in azure/login is deprecated (See also GitHub Actions: Transitioning from Node 16 to Node 20), and the pre execution is not supported.
Screenshot 2024-02-20 at 09 39 00

There are also several issues reported in the GitHub repo of azure/login:

And the pre execution issue seems to be originated from actions/runner#1478

In which platform does it happen?

GitHub Actions

How do we replicate the issue?

Those warnings appear on every testing logs.

Expected behavior (i.e. solution)

The warnings should be fixed.

Other Comments

Other GitHub Actions with similar issues have been upgraded:

See PR: Resolve issue #2018

@SimonYansenZhao SimonYansenZhao added the bug Something isn't working label Feb 20, 2024
@SimonYansenZhao
Copy link
Collaborator Author

Noticed that node.js version had been upgraded by Azure/login#411, but no new release has been published yet.

@SimonYansenZhao
Copy link
Collaborator Author

Fixed in #1937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant