Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Props type #5116

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

lifeofpavs
Copy link

Description

Updating Props type as a patch as mentioned on issue comment #3325 (comment)

Updated Props type to. accept BarRectangleItem type instead of any.

Related Issue

Motivation and Context

By updating the type the Cell component would be able to accept number array for the radius prop . Currently, the linter throws an error when trying to pass a number array.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@lifeofpavs lifeofpavs marked this pull request as ready for review October 15, 2024 10:19
@ckifer ckifer merged commit e3e31d1 into recharts:master Oct 15, 2024
4 checks passed
@ckifer
Copy link
Member

ckifer commented Oct 15, 2024

Thanks. I can't promise when this will get released

@lifeofpavs
Copy link
Author

Sure! Thanks a lot

@ckifer
Copy link
Member

ckifer commented Oct 29, 2024

Released in 2.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants