Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling selectors #1626

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Allow disabling selectors #1626

merged 1 commit into from
Nov 4, 2024
+2 −2

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 31, 2024

There was a bug with how we render a Python bool value into JavaScript. This PR fixes that issue.

Closes #1620

@humitos
Allow disabling selectors
Loading
Loading status checks…
573d8e0 
There was a bug with how we render a Python bool value into JavaScript.
This PR fixes that issue.

Closes #1620
@humitos humitos requested a review from a team as a code owner October 31, 2024 14:53
agjohnson
agjohnson approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch that either of these were boolean, I assumed they were query selector strings. This is where I prefer to use naming to illustration the variable use: hasVersionSelector and hasLanguageSelector are more obviously boolean.

@humitos humitos merged commit 5db7796 into master Nov 4, 2024
6 of 7 checks passed
@humitos humitos deleted the humitos/disable-version-selectors branch November 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version selector appears even with 'version_selector': False
2 participants
@humitos @agjohnson