Fix AttributeError when one of css_files
is a string
#1537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the last version of #1528 still did not work properly in some cases.
When
css_files
comes from Sphinx, every item of this list is an instance of_CascadingStyleSheet
class, andcss_tag
works with it.However, some projects override
css_files
in their templates:or pass
css_files
to HTML context explicitly fromconf.py
:To make build of these projects succeed, we need to support
css_file
being a string.Here I copied the logic from Sphinx itself.
See this Debian bug for the logs of the failed builds.