Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop creating readthedocs-sphinx-domain-names.json #122

Merged
merged 2 commits into from Jun 21, 2023
Merged

Stop creating readthedocs-sphinx-domain-names.json #122

merged 2 commits into from Jun 21, 2023

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 20, 2023

After we have deployed readthedocs/readthedocs.org#10451, we won't be needing that file.

@stsewd stsewd requested a review from ericholscher June 20, 2023 21:26
ericholscher
ericholscher approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a useful thing, but definitely too much complexity for the value it provided..

@stsewd stsewd enabled auto-merge (squash) June 21, 2023 15:51
@stsewd stsewd disabled auto-merge June 21, 2023 15:51
@stsewd stsewd merged commit 17fa51d into main Jun 21, 2023
6 of 7 checks passed
@stsewd stsewd deleted the stop-indexing-sphinx-domains branch June 21, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stsewd @ericholscher