Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HttpClient#mapConnect() / #doOnRequestError() are called when HttpClient#headersWhen() is used #2912

Merged
merged 1 commit into from Sep 28, 2023
Merged

Ensure HttpClient#mapConnect() / #doOnRequestError() are called when HttpClient#headersWhen() is used #2912

merged 1 commit into from Sep 28, 2023

Conversation

violetagg
Copy link
Member

Fixes #2904

@violetagg violetagg added the type/bug A general bug label Sep 28, 2023
@violetagg violetagg added this to the 1.0.37 milestone Sep 28, 2023
@violetagg violetagg requested a review from a team September 28, 2023 08:49
@violetagg violetagg linked an issue Sep 28, 2023 that may be closed by this pull request
.mapConnect() and .doOnRequestError() are not called when .headersWhen() is used #2904
Closed
@violetagg
Copy link
Member Author

failing tests on Windows CI are not related to this change

@violetagg violetagg merged commit 8734d97 into 1.0.x Sep 28, 2023
8 of 9 checks passed
@violetagg violetagg deleted the issue-2904 branch September 28, 2023 09:30
violetagg added a commit that referenced this pull request Sep 28, 2023
@violetagg
Merge #2912 into 1.1.12
a8bc2b6
@sullis sullis mentioned this pull request Feb 18, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/bug A general bug
Projects
None yet
Milestone
1.0.37
Development

Successfully merging this pull request may close these issues.

.mapConnect() and .doOnRequestError() are not called when .headersWhen() is used
2 participants
@violetagg @pderop