Improve Mono#share javadoc for cancelling
#3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to Flux#share, Mono#share also cancels the source when all Subscribers have cancelled. This change improves the documentation. Following #2680 and #2756 there exists a misalignment in the javadoc for Mono#share method. Since cancelling the source is a fact, the javadoc is now improved instead of changing the behaviour. Resolves #3740
chemicL
force-pushed
the
mono-share-cancellation-documentation
branch
from
9344e75
to
f4af9da
Compare
violetagg
approved these changes
Mar 7, 2024
|
Thx @violetagg ! |
|
@chemicL this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
chemicL
added a commit
that referenced
this pull request
Mar 7, 2024
violetagg
changed the title
violetagg
changed the title
Mono#share javadoc for cancelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
Flux#share,Mono#sharealso cancels the source when allSubscribers have cancelled. This change improves the documentation.Following #2680 and #2756 there exists a misalignment in the javadoc for
Mono#sharemethod. Since cancelling the source is a fact, the javadoc is now improved instead of changing the behaviour.Resolves #3740