New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stress test expectation and bug in ColdTestPublisher
#3700
Conversation
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3633) | ||
//@JCStressTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Ignore, flaky test (https://github.com/reactor/reactor-core/issues/3633) | |
//@JCStressTest | |
@JCStressTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the other tests can now have the ignores removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that the tests are effectively disabled at the moment. As this PR aims to fix the flakiness, these tests can be re-enabled.
@chemicL this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
The related tests can be uncommented as a follow-up. |
ColdTestPublisher
This PR fixes an early termination bug in
ColdTestPublisher
which happens when request from the downstream subscriber races with new values and following termination which in rare case endups in termination without propagation of the remaining values. Also this PR improves expectation for the stress test where ColdTestPulisher takes a key rolecloses #3633