Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensures cancel handler is wrapped in try catch and drops potential cancellation failure #3485

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

OlegDokuka
Copy link
Contributor

closes #3417

Unverified

No user is associated with the committer email.
…ncellation failure

Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: OlegDokuka <odokuka@vmware.com>
@OlegDokuka OlegDokuka requested a review from a team as a code owner June 2, 2023 08:24
@OlegDokuka OlegDokuka changed the base branch from main to 3.4.x June 2, 2023 08:24
@OlegDokuka OlegDokuka added the type/bug A general bug label Jun 2, 2023
@OlegDokuka OlegDokuka added this to the 3.4.30 milestone Jun 2, 2023
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment and we can 🚢

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…onStageTest.java

Co-authored-by: Dariusz Jędrzejczyk <jdariusz@vmware.com>
@OlegDokuka OlegDokuka merged commit 62142ee into 3.4.x Jun 8, 2023
@reactorbot
Copy link

@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@OlegDokuka OlegDokuka deleted the 3.4.x-3417 branch June 8, 2023 08:37
OlegDokuka pushed a commit that referenced this pull request Jun 8, 2023

Unverified

No user is associated with the committer email.
Signed-off-by: OlegDokuka <odokuka@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono.fromCompletionStage fails to propagate error signal when exception is thrown in map, flatMap and handle
3 participants