context-propagation: Use new ThreadLocalAccessor contract #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2023
chemicL
added
area/context
marcingrzejszczak
force-pushed
the
passNullPreviousValues
branch
from
452817a
to
4498fb5
Compare
|
@OlegDokuka this follows from micrometer-metrics/context-propagation#103 and once context-propagation is released (the week of June 5-9), we can include this in the next release (June 13). Once we merge micrometer-metrics/context-propagation#105 and release (I don't expect this to be a part of the nearest release, but rather a month later) we can further improve reactor's codebase to not include a custom implementation, but use the context-propagation library directly as it should then allow clearing the missing ThreadLocals. |
OlegDokuka
approved these changes
May 29, 2023
|
@chemicL sounds good to me |
chemicL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this change we can't distinguish in Micrometer (e.g. via
ObservationThreadLocalAccessor) whether we're introducing an empty value (setValue(null)) or resettingreset().with this change we always set a value regardless whether it's
nullor notThis change is a prerequisite to fix current issues with OTLA and Reactor and scope leaks and memory leaks etc.