Generating function component by default #1271
Merged
+67
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
reviewed
May 6, 2023
ahangarha
force-pushed
the
add-option-for-generating-functional-component
branch
from
c175289 to
d341357
Compare
ahangarha
changed the title
ahangarha
force-pushed
the
add-option-for-generating-functional-component
branch
from
1d2bc96 to
f755896
Compare
ahangarha
force-pushed
the
add-option-for-generating-functional-component
branch
from
45d1bbe to
bd15add
Compare
ahangarha
force-pushed
the
add-option-for-generating-functional-component
branch
from
3e1c346 to
7361cb8
Compare
Judahmeek
requested changes
Jul 20, 2023
CHANGELOG.md
Outdated
| @@ -21,6 +21,9 @@ _Please add entries here for your pull requests that are not yet released._ | |||
| #### Bug Fixes | |||
| - Fix ReactDomClient initialization error during SSR. #1278 | |||
|
|
|||
| #### Changed | |||
| - The `react:component` generator now generates a function component by default #1271 | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't this PR go under "unreleased" rather then under 2.7.1, which was released last month?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the functionality of component generation by creating function components.
Pull Request checklist
Other Information
Closes #1067