Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7 release #1209

Closed
5 of 6 tasks
justin808 opened this issue Oct 19, 2022 · 7 comments
Closed
5 of 6 tasks

2.7 release #1209

justin808 opened this issue Oct 19, 2022 · 7 comments
Assignees

Comments

@justin808
Copy link
Collaborator

justin808 commented Oct 19, 2022

If you have feedback on what's needed for a 2.7 release, please comment!

TODO for 2.7

  • Update changelog for diffs since 2.6.2
  • Verify the latest Shakapacker works with React-Rails
  • Confirm support for latest React 18 via Shakapacker
  • Consider updating the versions of React packaged with react-rails
  • Update to React 17 latest, as this was done for React 16
  • Update Sample App to master with latest Shakapacker
@justin808 justin808 changed the title v3 or 2.7 release 2.7 release Oct 19, 2022
@justin808 justin808 added this to the 2.7 milestone Oct 19, 2022
@ahangarha
Copy link
Collaborator

With the guideline I wrote in README file (#1214) I can verify react-rails works fine with Shakapacker. (For Rails 6 and 7)

@ahangarha
Copy link
Collaborator

I also think we should add test for React-Rails + Shakapacker. I don't know if we should keep the test for React-Rails + Webpacker or not.

@justin808
Copy link
Collaborator Author

Webpacker v5.4 and before should work.

If the migration to shakapacker should be straightforward, then we should require that for react-rails v3.

@justin808
Copy link
Collaborator Author

@ahangarha what's left for 2.7 release? can you check off items as completed?

@ahangarha
Copy link
Collaborator

ahangarha commented Nov 7, 2022

This is the status:

  • ✅ Update changelog for diffs since 2.6.2
  • ✅ Verify the latest Shakapacker works with React-Rails
  • ⏭️ Confirm support for latest React 18 via Shakapacker
  • ⏭️ Consider updating the versions of React packaged with react-rails
  • ⏭️ Update to React 17 latest, as this was done for React 16
  • ⚠️ Update Sample App to master with latest Shakapacker

Tomorrow I can work on checking react 18 with shakapacker and hopefully upgrade to React 17.0.2. Working on the sample app would take more time. Regarding the old versions of dependencies, I cannot give any estimation on how long it would talk time. For that I might need some support.

Also from other issues, I think we should include the following(s) in the list:

  • Update dependencies (webpack)

@ahangarha
Copy link
Collaborator

For "Update to react 17", I have done all of the steps except updating the version in lib/react/rails/version.rb which requires other updates and ultimately it requires (as per the comments in the file) running rake ujs:publish. Since this process generates many more files and tries updating npm package on npmjs.com, I didn't proceed further.

I need guidance for this step.

@justin808
Copy link
Collaborator Author

Shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants