Add AOT Friendly Attributes for BindingList<T> Compatibility #987
Conversation
Created a Polyfill for the `DynamicallyAccessedMembers` attribute / enum which isn't available until Net5. Updated any class using `BindingList` to include the `DynamicallyAccessedMembers` attribute so that the type have the same attributes as `BindingList`. Recursively walked up the code hierarchy to apply the attribute all the way up.
There was a problem hiding this comment.
PR Overview
This PR introduces AOT friendliness enhancements by adding a polyfill for the DynamicallyAccessedMembers attribute and applying it to various generic types that work with BindingList, while also converting several files to use file-scoped namespaces.
- Introduced a polyfill for DynamicallyAccessedMembersAttribute to support pre‑Net5 targets.
- Updated BindingList-related classes and extension methods to annotate generic parameters for AOT preservation.
- Converted multiple files to file‑scoped namespaces for consistency.
Reviewed Changes
| File | Description |
|---|---|
| src/DynamicData/Polyfills/DynamicallyAccessedMembersAttribute.cs | New polyfill implementation for the DynamicallyAccessedMembers attribute and associated enum. |
| src/DynamicData/Binding/BindingListAdaptor.cs | Updated to use file‑scoped namespace and applied the DynamicallyAccessedMembers attribute on the generic parameter. |
| src/DynamicData/Binding/SortedBindingListAdaptor.cs | Applied the DynamicallyAccessedMembers attribute on the generic parameter and updated namespace declaration. |
| src/DynamicData/Cache/ObservableCacheEx.SortAndBind.cs | Annotated generic methods with the DynamicallyAccessedMembers attribute and updated using directives. |
| src/DynamicData/Cache/ObservableCacheEx.cs | Updated extension methods to include attribute annotation on generic parameters. |
| src/DynamicData/List/ObservableListEx.cs | Modified to use file‑scoped namespace and applied the attribute on generic method parameters. |
| src/DynamicData/Binding/BindingListEventsSuspender.cs | Added the attribute on the generic parameter and updated using directives. |
| src/DynamicData/Binding/BindPaged.cs | Applied the DynamicallyAccessedMembers attribute on the generic parameter and updated namespace usage. |
| src/DynamicData/Binding/BindVirtualized.cs | Updated class declaration to include the attribute on the generic parameter and switched to file‑scoped namespace. |
| src/DynamicData/Binding/SortAndBind.cs | Annotated the generic parameter with DynamicallyAccessedMembers and updated using directives. |
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
dwcullop
assigned glennawatson, dwcullop and JakenVeina and unassigned glennawatson and JakenVeina
dwcullop
changed the title
Corrected the spelling of "similiar" to "similar" in the XML documentation comments throughout the `ObservableCacheEx` class. This change improves the clarity and professionalism of the documentation without affecting the code's functionality.
There was a problem hiding this comment.
Like I mentioned, I don't really have the context for whether this is functionally correct or appropriatte, but I don't see anything in the code that concerns me.
I will say that diffs on these files in GitHub are abysmal, I believe as a result of all the whitespace changes. Did something change recently with GitHub? Do we have any amount of configurability for how diffs are presented? If not, we maybe need to make a point to keep whitespace changes separate, for reviewability.
Those are the attributes that have gotten rid of AOT warnings for me in other projects. After the next release, I can confirm that they are indeed resolved. |
I'll release tomorrow |
|
This also annotates |
|
That seems to be correct, yes. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Created a Polyfill for the
DynamicallyAccessedMembersattribute / enum which isn't available until Net5.Updated any class using
BindingListto include theDynamicallyAccessedMembersattribute so that the type have the same attributes asBindingList.Recursively walked up the code hierarchy to apply the attribute all the way up.
All of the warnings mentioned in #983 were related to
BindingList<T>. Any generic code that uses that class directly (or indirectly) needs to have the same AOT attributes so that the trimmer will be sure to not trim needed type information, so this should resolve all of those warnings.Bonus Fixes
Converted two files to use file-scoped namespaces.