Upcoming v0.65.2 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.65 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.65.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

List of cherry picks

• facebook/react-native@efb359f
• facebook/react-native@91cac20
• facebook/react-native@c18a492
• facebook/react-native@49b3b31
• facebook/react-native@3827ca6

Local commits to backport to main

• facebook/react-native@cae0637
• facebook/react-native@f6accd2 (need to check if this is actually needed in main)
• facebook/react-native@5aae7fc

[danielgindi]

facebook/react-native@e35a963

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

[nextlevelbeard]

I believe the test automation community would highly appreciate these:
facebook/react-native@efb359f (facebook/react-native#31865)
facebook/react-native@91cac20 (facebook/react-native#31942)

Small but important fixes to the testID prop on Android builds.
It is currently not working with certain important components like TextInput and ScrollView.

[liamjones]

@danielgindi that was commented on in the last thread: #244 (comment)

That change is pretty major, and while it makes sense that people want it in a release, it might make sense to bake it longer at Facebook in case it needs to be reverted or tweaked to be stable at scale in the Facebook app.

[Bardiamist]

facebook/react-native@e35a963

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

By some reason after update React native from 0.64.2 to 0.65.0 (and 0.65.1) a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button). It's strange because worked fine in react-native@0.64.2. Looks critical for many users. Interesting why it's broken and will it help or no facebook/react-native@e35a963

[danielgindi]

facebook/react-native@e35a963

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

By some reason after update React native from 0.64.2 to 0.65.0 (and 0.65.1) a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button). It's strange because worked fine in react-native@0.64.2. Looks critical for many users. Interesting why it's broken and will it help or no facebook/react-native@e35a963

I do not believe that it has anything to do with overflows, so no, the fix for overflow touches won't help you with that.

[jonnyandrew]

facebook/react-native@c18a492 would be much appreciated! 😊

[mikehardy]

The event emitter comments were marked off-topic, and this may be as well but it's my experience that all the EventEmitter warnings are 3rd party modules, and as a maintainer we're working through them as fast as possible, but there are a lot. You'll just have to watch your modules and post PRs as you can, e.g.
software-mansion/react-native-reanimated#2297
react-native-netinfo/react-native-netinfo#487
invertase/react-native-firebase#5616
invertase/react-native-notifee#368
react-native-device-info/react-native-device-info#1289

etc etc etc :-). Please help with PRs if you can!

[dandre-hound]

Just resurfacing this 0.65.1 cherry pick discussion topic: #244 (comment)

facebook/react-native#31461 RefreshControl causes an unwanted visual jump in the list content when the refreshing prop goes from true to false

The commit causing the problem is this one facebook/react-native@1b0fb9b, PR is this one facebook/react-native#28236

Originally posted by the PR author @yogevbd in facebook/react-native#28236 (comment)

We believe this commit should be reverted until a proper fix is put in place. For the last two minor releases, pull to refresh on any type of list results in a visual jump that makes the refresh experience awkward and not smooth. The intent of the original PR was to fix this issue on large header styles, but the issue now appears on all non-large header styles. The issue is also easily reproducible and could be reverted cleanly.

[mikehardy]

I recognize 0.65.2 may or may not happen, but if it does this is important for anyone using javascript debugging (which is a lot of people...) to avoid a redbox facebook/react-native@49b3b31

[RigottiG]

facebook/react-native@e35a963

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

By some reason after update React native from 0.64.2 to 0.65.0 (and 0.65.1) a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button). It's strange because worked fine in react-native@0.64.2. Looks critical for many users. Interesting why it's broken and will it help or no facebook/react-native@e35a963

I do not believe that it has anything to do with overflows, so no, the fix for overflow touches won't help you with that.

Actually, I tested it with version v0.66.0-rc.0 which has these fixes facebook/react-native@e35a963 and apparently it fixes the react-navigation problem too.

U can see more details about react-navigation's issue here

It would be very important to cherry-pick these fixes in version 0.65.2.

[ghost]

Do we have any expectations to release this version? I'm just asking because the facebook/react-native@e35a963 fix is really important for us.

Thank you for the hard work!

[danielgindi]

Actually, I tested it with version v0.66.0-rc.0 which has these fixes facebook/react-native@e35a963 and apparently it fixes the react-navigation problem too.

Although this may work with the overflow fix- it would only be a workaround. The reason for the regression in behavior is not lack of overflow touches, as this has always been the case. It is probably some dimensions issue with react-navigation.
It should better be fixed at source before the bug comes later and bites you in the behind.

[r0b0t3d]

facebook/react-native@7edf927

Fix keyboardDismissMode="on-drag" on Android

[mikehardy]

@r0b0t3d you will definitely want to propose this on #246 as well - 0.66 is closing in on release and 0.65.2 may never hapepn

[kelset]

hey folks, it's likely that at least one more patch for 0.65 will happen; I've updated the top post with the commits that have been requested so far that I feel confident we could (at least try to) cherry pick.

This leaves out (unless I missed something):

• reverting facebook/react-native@1b0fb9b
• cherry picking facebook/react-native@e35a963 which in line with what Eli said we shouldn't try to "backport" - 0.66 is already in the works so it will be there

I won't be working on this today but wanted to check the status here and provide an update.

[christianbach]

Would be great if you could consider picking:
facebook/react-native@29249e1

Summary:
This change allows native activities and fragments to also handle onActivityResult callbacks, in addition to sending the result to React Native.

[ghost]

@kelset Any updates? I Saw that there are plans to release 0.66.4 next week...

[kelset]

Yes the current focus is all on 0.66 (rc4 was just released). I haven't had time to work on a patch release for 0.65, so it's likely that we'll just ask folks to update to 0.66 since it's basically the first release that will still be "pretty close" to main branch and will make things easier looking ahead.

[ghost]

Nice! Thank you.

[ghost]

@kelset I think this issue can be closed since there is already a stable 0.66.0 version.

[kelset]

yeah, sorry was off sick these past few days. Let's close this. Hopefully migration to 0.66 will be smooth for y'all 🤞