Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validateFieldsNatively): handle undefined object when reading 'refs' #734

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jorisre
Copy link
Member

@jorisre jorisre commented Jan 28, 2025

Added a missing check to ensure field is defined, similar to the existing check in the preceding if condition.

Fixes #692

@bluebill1049 Review is welcome, but please don’t merge. Thank you!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jorisre jorisre requested a review from bluebill1049 January 28, 2025 12:30
Copy link
Contributor

Size Change: -1 B (0%)

Total Size: 31.5 kB

Filename Size Change
dist/resolvers.js 444 B -2 B (-0.45%)
dist/resolvers.umd.js 538 B +1 B (+0.19%)
ℹ️ View Unchanged
Filename Size
ajv/dist/ajv.js 692 B
ajv/dist/ajv.module.js 646 B
ajv/dist/ajv.umd.js 803 B
arktype/dist/arktype.js 306 B
arktype/dist/arktype.module.js 321 B
arktype/dist/arktype.umd.js 408 B
class-validator/dist/class-validator.js 537 B
class-validator/dist/class-validator.module.js 560 B
class-validator/dist/class-validator.umd.js 640 B
computed-types/dist/computed-types.js 385 B
computed-types/dist/computed-types.module.js 401 B
computed-types/dist/computed-types.umd.js 476 B
dist/resolvers.module.js 454 B
effect-ts/dist/effect-ts.js 442 B
effect-ts/dist/effect-ts.module.js 458 B
effect-ts/dist/effect-ts.umd.js 545 B
fluentvalidation-ts/dist/fluentvalidation-ts.js 488 B
fluentvalidation-ts/dist/fluentvalidation-ts.module.js 508 B
fluentvalidation-ts/dist/fluentvalidation-ts.umd.js 575 B
io-ts/dist/io-ts.js 1.27 kB
io-ts/dist/io-ts.module.js 1.15 kB
io-ts/dist/io-ts.umd.js 1.39 kB
joi/dist/joi.js 590 B
joi/dist/joi.module.js 606 B
joi/dist/joi.umd.js 694 B
nope/dist/nope.js 347 B
nope/dist/nope.module.js 366 B
nope/dist/nope.umd.js 435 B
superstruct/dist/superstruct.js 324 B
superstruct/dist/superstruct.module.js 343 B
superstruct/dist/superstruct.umd.js 424 B
typanion/dist/typanion.js 329 B
typanion/dist/typanion.module.js 344 B
typanion/dist/typanion.umd.js 425 B
typebox/dist/typebox.js 501 B
typebox/dist/typebox.module.js 518 B
typebox/dist/typebox.umd.js 616 B
typeschema/dist/typeschema.js 468 B
typeschema/dist/typeschema.module.js 480 B
typeschema/dist/typeschema.umd.js 576 B
valibot/dist/valibot.js 475 B
valibot/dist/valibot.module.js 489 B
valibot/dist/valibot.umd.js 583 B
vest/dist/vest.js 479 B
vest/dist/vest.module.js 443 B
vest/dist/vest.umd.js 568 B
vine/dist/vine.js 532 B
vine/dist/vine.module.js 542 B
vine/dist/vine.umd.js 639 B
yup/dist/yup.js 622 B
yup/dist/yup.module.js 636 B
yup/dist/yup.umd.js 726 B
zod/dist/zod.js 599 B
zod/dist/zod.module.js 618 B
zod/dist/zod.umd.js 703 B

compressed-size-action

@jorisre jorisre merged commit 3da2054 into master Jan 30, 2025
4 checks passed
@jorisre jorisre deleted the fix/validateFieldsNatively-undefined-field branch January 30, 2025 13:05
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using useFieldArray, shouldUseNativeValidation: true and joiResolver together causes a bug
2 participants