Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 ci: cleanup actions versions #11629

Merged
merged 2 commits into from Mar 13, 2024
Merged

💚 ci: cleanup actions versions #11629

merged 2 commits into from Mar 13, 2024

Conversation

Moshyfawn
Copy link
Member

@Moshyfawn Moshyfawn commented Mar 13, 2024

Closes: #11627

  • Most of the CI warnings are due to the recent Node 20 push, which is resolved by upgrading to the latest Node action version.
  • For the cron job locking action specific warnings, I believe upgrading to the latest action version introduces the necessary changes to the API to address them.
  • The CodeQL action may be redundant as this is now natively built into GitHub and can be operated and set up following this guide via repository settings, which I don't have permissions to do.
  • I don't think we can do anything with the Package Size action, which doesn't specify the Node version in its configuration, so it will probably just be forced to run on Node 16 once GitHub makes the switch. It doesn't seem to be very well maintained at the moment, but there aren't many other alternatives to choose from at the moment, as almost all of them seem to be unmaintained. The upstream PR that would solve this is Move to node20, release v3 preactjs/compressed-size-action#103

Copy link

codesandbox bot commented Mar 13, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

Size Change: 0 B

Total Size: 20.7 kB

ℹ️ View Unchanged
Filename Size
dist/index.cjs.js 10.3 kB
dist/index.umd.js 10.4 kB

compressed-size-action

Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bluebill1049 bluebill1049 merged commit b300a65 into master Mar 13, 2024
7 checks passed
@bluebill1049 bluebill1049 deleted the ci/cleanup branch March 13, 2024 21:45
rafaelcalhau pushed a commit to rafaelcalhau/react-hook-form that referenced this pull request May 5, 2024
* 💚 ci(Node): bump node action version

* 💚 ci(Issues): bump lock issue action version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue: workflows using deprecated/soon to be disabled actions and commands
2 participants