Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug(validatingFields, trigger): handle all fields validation trigger #11624

Merged
merged 7 commits into from Mar 15, 2024

Conversation

Moshyfawn
Copy link
Member

Closes #11621

Copy link

codesandbox bot commented Mar 12, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@Moshyfawn Moshyfawn changed the title WIP 🐛 bug(validatingFields, trigger): handle all fields validation trigger 🐛 bug(validatingFields, trigger): handle all fields validation trigger Mar 12, 2024
Copy link
Contributor

github-actions bot commented Mar 12, 2024

Size Change: +23 B (0%)

Total Size: 20.8 kB

Filename Size Change
dist/index.cjs.js 10.3 kB +12 B (0%)
dist/index.umd.js 10.4 kB +11 B (0%)

compressed-size-action

@Moshyfawn Moshyfawn marked this pull request as ready for review March 12, 2024 20:39
@bluebill1049
Copy link
Member

thanks @Moshyfawn let me double check this over the weekend.

@Moshyfawn
Copy link
Member Author

thanks @Moshyfawn let me double check this over the weekend.

For sure! I'm a bit unsure if the _mount fields are the best way to implement this, but I haven't found any way to retrieve the necessary fields other than mapping over them at the moment.

@Moshyfawn Moshyfawn force-pushed the fix/trigger-all-validating-fields branch from fa8fbd5 to c7bd545 Compare March 13, 2024 21:50
@bluebill1049 bluebill1049 merged commit 4632f8a into master Mar 15, 2024
7 checks passed
@bluebill1049 bluebill1049 deleted the fix/trigger-all-validating-fields branch March 15, 2024 23:31
@BijayKumarSahoo
Copy link

image
Issue since, 7.51.1 version.
Happens when Devtool component is used, entry into any input fields lags and gives above error, doesn't allow inputting fast.

rafaelcalhau pushed a commit to rafaelcalhau/react-hook-form that referenced this pull request May 5, 2024
react-hook-form#11624)

* WIP 🐛 bug(validatingFields, trigger): handle all fields validation trigger

* 🔧 chore: update lock file

* 🐛 bug(validatingFields, trigger): handle all fields validation trigger

* 🔧 chore: remove todo comment

* fix react-hook-form#11621 issue with undefined name as field name

* fix lint

* revert change on trigger

---------

Co-authored-by: bill <bluebill1049@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue: validatingFields includes "undefined" as field name
3 participants