Fix data param in handleSubmit when TTransformedValues is a union type #11420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Ar4ys
force-pushed
the
fix-ttransformedvalues-with-union
branch
from
041b367
to
2f004e3
Compare
Ar4ys
commented
Jan 20, 2024
| @@ -769,6 +765,7 @@ export type BatchFieldArrayUpdate = < | |||
| export type Control< | |||
| TFieldValues extends FieldValues = FieldValues, | |||
| TContext = any, | |||
| TTransformedValues extends FieldValues = TFieldValues, | |||
There was a problem hiding this comment.
Despite adding new generic to Control, this should not be a breaking change, because TTransformedValues has a default value of TFieldValues, so previous code that only specified TFieldValues should still work as expected.
1 task
1 task
rafaelcalhau
pushed a commit
to rafaelcalhau/react-hook-form
that referenced
this pull request
May 5, 2024
…ype (react-hook-form#11420) * Rewritten UseFormHandleSubmit to use default values in generics * Updated api-extractor report --------- Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
rafaelcalhau
pushed a commit
to rafaelcalhau/react-hook-form
that referenced
this pull request
May 5, 2024
… union type (react-hook-form#11420)" This reverts commit 6fee03c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replaces current
UseFormHandleSubmitimplementation with the one that relies on default values in generics. For more info see this comment in original issue: #11414 (comment)Fixes #11414
Type of change
Please delete options that are not relevant.
Checklist: