refactor: Move hide event to mouseDown
#446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 97.87% 97.68% -0.20%
==========================================
Files 13 13
Lines 799 776 -23
Branches 235 221 -14
==========================================
- Hits 782 758 -24
- Misses 17 18 +1 ☔ View full report in Codecov by Sentry. |
|
那一个节点，降低覆盖率了，哪里都看不到 |
|
覆盖率下降是因为修改文件行变少了，总覆盖率下降。不是改动的代码覆盖率降了： |
crazyair
approved these changes
Mar 7, 2024
https://app.codecov.io/gh/react-component/trigger/pull/446/indirect-changes 这一行没覆盖了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref ant-design/ant-design#47671
看了一下过去行为，的确是
mouseDown关闭更合理。调整一下事件，另外就是过去有一个 test 写的是元素stopPop可以让 Trigger 不关闭，之后又有一个 bug 是点击了stopPop元素时 Trigger 没有关闭。这两个本身是矛盾的，按照原生看以无论如何点击就关闭为准。