feat: support clearOnDestroy #692
Merged
+127
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 18 18
Lines 1247 1249 +2
Branches 304 305 +1
=======================================
+ Hits 1240 1242 +2
Misses 7 7 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
May 9, 2024
zombieJ
reviewed
May 9, 2024
| @@ -165,6 +165,10 @@ export class FormStore { | |||
| }); | |||
|
|
|||
| this.prevWithoutPreserves = prevWithoutPreserves; | |||
| if (clearStoreOnDestroy) { | |||
| // destroy form reset store | |||
| this.updateStore({}); | |||
There was a problem hiding this comment.
这个 updateStore 就是恢复，反而 setInitialValues 不能恢复，因为
There was a problem hiding this comment.
不太明白，就是有 initialValues，然后我卸载了，在 Mount。这个 store 里没有 initialValues？
There was a problem hiding this comment.
clearStoreOnDestroy 的目标是 Form 卸载清空 store，还是恢复 initialValues？
zombieJ
reviewed
May 10, 2024
zombieJ
approved these changes
May 13, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.