feat: support id prop #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
添加用例?亲. |
|
好嘞 |
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 143 143
Branches 53 53
=========================================
Hits 143 143
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zombieJ
reviewed
Jun 20, 2023
src/DrawerPopup.tsx
Outdated
| @@ -318,6 +321,7 @@ function DrawerPopup(props: DrawerPopupProps, ref: React.Ref<HTMLDivElement>) { | |||
| return ( | |||
| <DrawerContext.Provider value={mergedContext}> | |||
| <div | |||
| id={id} | |||
There was a problem hiding this comment.
位置不对，id 和 className 一样都是加在弹出 Panel 上的
There was a problem hiding this comment.
看原 issue 里的说法，一开始好像放在最外层的，大佬要不再确认下@zombieJ
zombieJ
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持 id prop
close ant-design/ant-design#42987