Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Progress bar and spinner spacing #6873

Merged

Conversation

VibhorJaiswal
Copy link
Contributor

fix: #6872

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@VibhorJaiswal VibhorJaiswal marked this pull request as ready for review November 24, 2024 16:03
@@ -9,6 +9,15 @@
margin: 0.25rem 0.25rem;
}

.progress {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge these selectors with the above btn and btn-group

@VibhorJaiswal VibhorJaiswal marked this pull request as draft November 25, 2024 06:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@VibhorJaiswal VibhorJaiswal marked this pull request as ready for review November 25, 2024 13:40
@VibhorJaiswal
Copy link
Contributor Author

Hi! @kyletsang, I've implemented the changes based on your suggestions. Could you please review and let me know if it looks good now?

@kyletsang kyletsang merged commit 2429860 into react-bootstrap:master Dec 1, 2024
7 of 12 checks passed
@kyletsang
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gapping in Progress bars and Spinners is incorrect
2 participants